@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Better JS for Differential File Collapsing Undo
Summary: take epriestley's feedback 'cuz its good
Test Plan: collapse, expand, use undo like a rockstar. observe proper behavior
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, aran
Maniphest Tasks: T2258
Differential Revision: https://secure.phabricator.com/D6748
+16
-14
+16
-14
webroot/rsrc/js/application/differential/behavior-toggle-files.js
+16
-14
webroot/rsrc/js/application/differential/behavior-toggle-files.js
···
18
18
}
19
19
20
20
var diff = e.getData().diff[0],
21
-
data = JX.Stratcom.getData(diff),
22
-
undo;
21
+
data = JX.Stratcom.getData(diff);
23
22
if (data.hidden) {
24
23
data.hidden = false;
25
24
JX.DOM.show(diff);
26
-
undo = JX.DOM.find(diff.parentNode,
27
-
'div',
28
-
'differential-collapse-undo-div');
29
-
JX.DOM.remove(undo);
25
+
JX.DOM.remove(data.undo);
26
+
data.undo = null;
30
27
} else {
31
28
data.hidden = true;
29
+
data.undo = render_collapse_undo();
32
30
JX.DOM.hide(diff);
33
-
undo = render_collapse_undo();
34
-
JX.DOM.listen(undo, 'click', 'differential-collapse-undo', function(e) {
35
-
e.kill();
36
-
data.hidden = false;
37
-
JX.DOM.show(diff);
38
-
JX.DOM.remove(undo);
39
-
});
40
-
JX.DOM.appendContent(diff.parentNode, undo);
31
+
JX.DOM.listen(
32
+
data.undo,
33
+
'click',
34
+
'differential-collapse-undo',
35
+
function(e) {
36
+
e.kill();
37
+
data.hidden = false;
38
+
JX.DOM.show(diff);
39
+
JX.DOM.remove(data.undo);
40
+
data.undo = null;
41
+
});
42
+
JX.DOM.appendContent(diff.parentNode, data.undo);
41
43
}
42
44
JX.Stratcom.invoke('differential-toggle-file-toggled');
43
45
});