@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Convert Create/Edit Column pages to dialogs
Summary: Makes these pages a dialog endpoint, keeping you on the Workboard when possible.
Test Plan: Create a Column, Edit a Column, visit hard page. Test letters in the points field.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15270
+7
-15
+1
-1
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+1
-1
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+6
-14
src/applications/project/controller/PhabricatorProjectColumnEditController.php
+6
-14
src/applications/project/controller/PhabricatorProjectColumnEditController.php
···
136
136
$submit = pht('Save Column');
137
137
}
138
138
139
-
$form->appendChild(
140
-
id(new AphrontFormSubmitControl())
141
-
->setValue($submit)
142
-
->addCancelButton($view_uri));
143
-
144
-
$form_box = id(new PHUIObjectBoxView())
145
-
->setHeaderText($title)
139
+
return $this->newDialog()
140
+
->setWidth(AphrontDialogView::WIDTH_FORM)
141
+
->setTitle($title)
142
+
->appendForm($form)
146
143
->setValidationException($validation_exception)
147
-
->setForm($form);
148
-
149
-
$nav = $this->getProfileMenu();
144
+
->addCancelButton($view_uri)
145
+
->addSubmitButton($submit);
150
146
151
-
return $this->newPage()
152
-
->setTitle($title)
153
-
->setNavigation($nav)
154
-
->appendChild($form_box);
155
147
}
156
148
}