@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't try to access the Stripe object until the user submits the credit card form
Summary: Ref T12232. I can't reproduce the original issue, but this should probably fix it without side effects?
Test Plan: Added a card with Stripe, but I could do that before too.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12232
Differential Revision: https://secure.phabricator.com/D17333
+9
-8
+7
-7
resources/celerity/map.php
+7
-7
resources/celerity/map.php
···
433
433
'rsrc/js/application/passphrase/passphrase-credential-control.js' => '3cb0b2fc',
434
434
'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => 'bee502c8',
435
435
'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => 'fbe497e7',
436
-
'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '3f5d6dbf',
436
+
'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => 'a6b98425',
437
437
'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
438
438
'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
439
439
'rsrc/js/application/policy/behavior-policy-control.js' => 'd0c516d5',
···
712
712
'javelin-behavior-select-on-click' => '4e3e79a6',
713
713
'javelin-behavior-setup-check-https' => '491416b3',
714
714
'javelin-behavior-slowvote-embed' => '887ad43f',
715
-
'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
715
+
'javelin-behavior-stripe-payment-form' => 'a6b98425',
716
716
'javelin-behavior-test-payment-form' => 'fc91ab6c',
717
717
'javelin-behavior-time-typeahead' => '522431f7',
718
718
'javelin-behavior-toggle-class' => '92b9ec77',
···
1161
1161
'javelin-workflow',
1162
1162
'javelin-stratcom',
1163
1163
),
1164
-
'3f5d6dbf' => array(
1165
-
'javelin-behavior',
1166
-
'javelin-dom',
1167
-
'phortune-credit-card-form',
1168
-
),
1169
1164
'40a6a403' => array(
1170
1165
'javelin-install',
1171
1166
'javelin-dom',
···
1760
1755
'javelin-util',
1761
1756
'phuix-icon-view',
1762
1757
'phabricator-busy',
1758
+
),
1759
+
'a6b98425' => array(
1760
+
'javelin-behavior',
1761
+
'javelin-dom',
1762
+
'phortune-credit-card-form',
1763
1763
),
1764
1764
'a6f7a73b' => array(
1765
1765
'javelin-behavior',
+2
-1
webroot/rsrc/js/application/phortune/behavior-stripe-payment-form.js
+2
-1
webroot/rsrc/js/application/phortune/behavior-stripe-payment-form.js
···
6
6
*/
7
7
8
8
JX.behavior('stripe-payment-form', function(config) {
9
-
Stripe.setPublishableKey(config.stripePublishableKey);
10
9
11
10
function onsubmit(card_data) {
12
11
var errors = [];
12
+
13
+
Stripe.setPublishableKey(config.stripePublishableKey);
13
14
14
15
if (!Stripe.validateCardNumber(card_data.number)) {
15
16
errors.push('cc:invalid:number');