@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Give audit statuses API constants that match their UI strings

Summary: Ref T13631. These strings were a little inconsistent; make them more consistent.

Test Plan: Called `diffusion.commit.search` with the appropriate attachment, saw slightly more consistent statuses.

Maniphest Tasks: T13631

Differential Revision: https://secure.phabricator.com/D21600

+11 -2
+10 -1
src/applications/audit/constants/PhabricatorAuditRequestStatus.php
··· 37 37 return $this->key; 38 38 } 39 39 40 + public function getStatusValueForConduit() { 41 + return $this->getMapProperty('value.conduit'); 42 + } 43 + 40 44 public function isResigned() { 41 45 return ($this->key === self::RESIGNED); 42 46 } ··· 53 57 'name' => pht('Audit Required'), 54 58 'icon' => 'fa-exclamation-circle', 55 59 'icon.color' => 'orange', 60 + 'value.conduit' => 'audit-required', 56 61 ), 57 62 self::AUDIT_REQUESTED => array( 58 63 'name' => pht('Audit Requested'), 59 64 'icon' => 'fa-exclamation-circle', 60 65 'icon.color' => 'orange', 66 + 'value.conduit' => 'audit-requested', 61 67 ), 62 68 self::CONCERNED => array( 63 - 'name' => pht('concern Raised'), 69 + 'name' => pht('Concern Raised'), 64 70 'icon' => 'fa-times-circle', 65 71 'icon.color' => 'red', 72 + 'value.conduit' => 'concern-raised', 66 73 ), 67 74 self::ACCEPTED => array( 68 75 'name' => pht('Accepted'), 69 76 'icon' => 'fa-check-circle', 70 77 'icon.color' => 'green', 78 + 'value.conduit' => 'accepted', 71 79 ), 72 80 self::RESIGNED => array( 73 81 'name' => pht('Resigned'), 74 82 'icon' => 'fa-times', 75 83 'icon.color' => 'grey', 84 + 'value.conduit' => 'resigned', 76 85 ), 77 86 ); 78 87 }
+1 -1
src/applications/diffusion/engineextension/DiffusionAuditorsSearchEngineAttachment.php
··· 24 24 25 25 $list[] = array( 26 26 'auditorPHID' => $auditor->getAuditorPHID(), 27 - 'status' => $status->getStatusValue(), 27 + 'status' => $status->getStatusValueForConduit(), 28 28 ); 29 29 } 30 30