@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Toggle revision "shouldBroadcast" correctly when "--draft" is used with prototypes off
Summary:
See PHI573. Ref T13120. Drafts were recently changed so that "draft" and "broadcast" are separate flags, and you can have non-broadcasting revisions in states other than "draft" if builds fail on a draft or you abandon a draft.
However, when draft mode is entered with `arc diff --draft` and you have prototypes off, this flag wasn't being set correctly.
Test Plan: Disabled prototypes, created a revision with `arc diff --draft`, observed that `draft.broadcast` is now correctly `false`.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13120
Differential Revision: https://secure.phabricator.com/D19360
+3
-1
+3
-1
src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
+3
-1
src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
···
22
22
// TODO: This can probably be removed once Draft is the universal default.
23
23
if ($this->isNewObject()) {
24
24
if ($object->isNeedsReview()) {
25
-
$object->setModernRevisionStatus(DifferentialRevisionStatus::DRAFT);
25
+
$object
26
+
->setModernRevisionStatus(DifferentialRevisionStatus::DRAFT)
27
+
->setShouldBroadcast(false);
26
28
}
27
29
}
28
30
}