@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make bot macro handler more graceful in the face of failure
Summary: Fixes T5883. The first time we hit an error we'll continue forward; we only bail after the second time. Instead, check for an error immediately
Test Plan: HA HA HA DID NOT TEST HA HA HA HA
Reviewers: btrahan, cburroughs
Reviewed By: cburroughs
Subscribers: epriestley
Maniphest Tasks: T5883
Differential Revision: https://secure.phabricator.com/D10265
+5
+5
src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php
+5
src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php
···
68
68
$ascii = $this->macros[$macro]['ascii'];
69
69
}
70
70
71
+
if ($ascii === false) {
72
+
// If we failed to rasterize the macro, bail out.
73
+
return;
74
+
}
75
+
71
76
$target_name = $message->getTarget()->getName();
72
77
foreach ($ascii as $line) {
73
78
$this->replyTo($message, $line);