@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove the caret dropdown from transaction lists when no actions are available
Summary:
See PHI325. When a transaction group in Differential (or Pholio) only has an inline comment, it renders with a "V" caret but no actual dropdown menu.
This caret renders in a "disabled" color, but the color is "kinda grey". The "active" color is "kinda grey with a dab of blue". Here's what they look like today:
{F5401581}
Just remove it.
Test Plan: Viewed one of these, no longer saw the inactive caret.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18963
+6
-12
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'e68cf1fa',
11
11
'conpherence.pkg.js' => '15191c65',
12
-
'core.pkg.css' => '075f9867',
12
+
'core.pkg.css' => '51debec3',
13
13
'core.pkg.js' => '4c79d74f',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '45951e9e',
···
176
176
'rsrc/css/phui/phui-spacing.css' => '042804d6',
177
177
'rsrc/css/phui/phui-status.css' => 'd5263e49',
178
178
'rsrc/css/phui/phui-tag-view.css' => 'b4719c50',
179
-
'rsrc/css/phui/phui-timeline-view.css' => 'e2ef62b1',
179
+
'rsrc/css/phui/phui-timeline-view.css' => '6ddf8126',
180
180
'rsrc/css/phui/phui-two-column-view.css' => '44ec4951',
181
181
'rsrc/css/phui/workboards/phui-workboard-color.css' => '783cdff5',
182
182
'rsrc/css/phui/workboards/phui-workboard.css' => '3bc85455',
···
873
873
'phui-status-list-view-css' => 'd5263e49',
874
874
'phui-tag-view-css' => 'b4719c50',
875
875
'phui-theme-css' => '9f261c6b',
876
-
'phui-timeline-view-css' => 'e2ef62b1',
876
+
'phui-timeline-view-css' => '6ddf8126',
877
877
'phui-two-column-view-css' => '44ec4951',
878
878
'phui-workboard-color-css' => '783cdff5',
879
879
'phui-workboard-view-css' => '3bc85455',
+3
-5
src/view/phui/PHUITimelineEventView.php
+3
-5
src/view/phui/PHUITimelineEventView.php
···
301
301
302
302
$menu = null;
303
303
$items = array();
304
-
$has_menu = false;
305
304
if (!$this->getIsPreview() && !$this->getHideCommentOptions()) {
306
305
foreach ($this->getEventGroup() as $event) {
307
306
$items[] = $event->getMenuItems($this->anchor);
308
-
if ($event->hasChildren()) {
309
-
$has_menu = true;
310
-
}
311
307
}
312
308
$items = array_mergev($items);
313
309
}
314
310
315
-
if ($items || $has_menu) {
311
+
if ($items) {
316
312
$icon = id(new PHUIIconView())
317
313
->setIcon('fa-caret-down');
318
314
$aural = javelin_tag(
···
351
347
));
352
348
353
349
$has_menu = true;
350
+
} else {
351
+
$has_menu = false;
354
352
}
355
353
356
354
// Render "extra" information (timestamp, etc).