recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix wrong proto-English string for actions with no effect

Summary: The %s is the number of actions with no effect, not the total number of actions.

Test Plan:
- Switch locale to "raw strings"
- Apply two actions one of which has no effect.
- Without this patch see "Some of your 1 action(s) have no effect" which is wrong because you have 2 total actions.
- With this patch see "1 of your actions has no effect".
- Switch locale to US english and see the same things with and without the patch

Note that it's logically impossible for you to be making only one action here; at least one must have no effect (for the message to make sense), and at least one must have some effect (or else it prints a different message).

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26575

Pppery 40f95f98 97b8eb09

+2 -2
+1 -1
src/applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php
··· 36 36 37 37 if ($ex->hasAnyEffect()) { 38 38 $title = pht('%s Action(s) With No Effect', $count); 39 - $head = pht('Some of your %s action(s) have no effect:', $count); 39 + $head = pht('%s of your actions have no effect:', $count); 40 40 $tail = pht('Apply remaining actions?'); 41 41 $continue = pht('Apply Remaining Actions'); 42 42 } else if ($ex->hasComment()) {
+1 -1
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
··· 36 36 'Actions With No Effect', 37 37 ), 38 38 39 - 'Some of your %s action(s) have no effect:' => array( 39 + '%s of your actions have no effect:' => array( 40 40 'One of your actions has no effect:', 41 41 'Some of your actions have no effect:', 42 42 ),