recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Recover from `null` authors in commit parsing

Summary:
Fixes T5445. Some import tools and other unusual situations can leave repositories with commits that don't have authors. This fails on insert.

Instead, explicitly cast the value to a string.

Test Plan: I didn't build a local repro, but see task/GitHub.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5445

Differential Revision: https://secure.phabricator.com/D9684

epriestley 40fa4799 19ff097d

+1 -1
+1 -1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
··· 17 17 $data = new PhabricatorRepositoryCommitData(); 18 18 } 19 19 $data->setCommitID($commit->getID()); 20 - $data->setAuthorName($author); 20 + $data->setAuthorName((string)$author); 21 21 $data->setCommitDetail( 22 22 'authorPHID', 23 23 $this->resolveUserPHID($commit, $author));