@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Mark `renderActionDescription` as abstract
Summary:
I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:
```
Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()
/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896
```
Test Plan: N/A
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D13779
+2
+2
src/applications/herald/action/HeraldAction.php
+2
src/applications/herald/action/HeraldAction.php
···
23
23
abstract public function supportsRuleType($rule_type);
24
24
abstract public function applyEffect($object, HeraldEffect $effect);
25
25
26
+
abstract public function renderActionDescription($value);
27
+
26
28
protected function renderActionEffectDescription($type, $data) {
27
29
return null;
28
30
}