@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove the "Edit Multiple Files" external editor setting
Summary: Ref T13515. No callsites actually use this, most editors don't support it, it doesn't seem terribly useful for the ones that do, it makes template-based APIs for line-number substitution complicated, and we can probably just loop on `window.open()` anyway.
Test Plan: Grepped for affected symbols, found no more references. Loaded settings page, saw no more setting.
Maniphest Tasks: T13515
Differential Revision: https://secure.phabricator.com/D21142
-55
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
3274
3274
'PhabricatorEditorExtension' => 'applications/transactions/engineextension/PhabricatorEditorExtension.php',
3275
3275
'PhabricatorEditorExtensionModule' => 'applications/transactions/engineextension/PhabricatorEditorExtensionModule.php',
3276
3276
'PhabricatorEditorMailEngineExtension' => 'applications/transactions/engineextension/PhabricatorEditorMailEngineExtension.php',
3277
-
'PhabricatorEditorMultipleSetting' => 'applications/settings/setting/PhabricatorEditorMultipleSetting.php',
3278
3277
'PhabricatorEditorSetting' => 'applications/settings/setting/PhabricatorEditorSetting.php',
3279
3278
'PhabricatorElasticFulltextStorageEngine' => 'applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php',
3280
3279
'PhabricatorElasticsearchHost' => 'infrastructure/cluster/search/PhabricatorElasticsearchHost.php',
···
9735
9734
'PhabricatorEditorExtension' => 'Phobject',
9736
9735
'PhabricatorEditorExtensionModule' => 'PhabricatorConfigModule',
9737
9736
'PhabricatorEditorMailEngineExtension' => 'PhabricatorMailEngineExtension',
9738
-
'PhabricatorEditorMultipleSetting' => 'PhabricatorSelectSetting',
9739
9737
'PhabricatorEditorSetting' => 'PhabricatorStringSetting',
9740
9738
'PhabricatorElasticFulltextStorageEngine' => 'PhabricatorFulltextStorageEngine',
9741
9739
'PhabricatorElasticsearchHost' => 'PhabricatorSearchHost',
-13
src/applications/people/storage/PhabricatorUser.php
-13
src/applications/people/storage/PhabricatorUser.php
···
478
478
479
479
$editor = $this->getUserSetting(PhabricatorEditorSetting::SETTINGKEY);
480
480
481
-
if (is_array($path)) {
482
-
$multi_key = PhabricatorEditorMultipleSetting::SETTINGKEY;
483
-
$multiedit = $this->getUserSetting($multi_key);
484
-
switch ($multiedit) {
485
-
case PhabricatorEditorMultipleSetting::VALUE_SPACES:
486
-
$path = implode(' ', $path);
487
-
break;
488
-
case PhabricatorEditorMultipleSetting::VALUE_SINGLE:
489
-
default:
490
-
return null;
491
-
}
492
-
}
493
-
494
481
if (!strlen($editor)) {
495
482
return null;
496
483
}
-40
src/applications/settings/setting/PhabricatorEditorMultipleSetting.php
-40
src/applications/settings/setting/PhabricatorEditorMultipleSetting.php
···
1
-
<?php
2
-
3
-
final class PhabricatorEditorMultipleSetting
4
-
extends PhabricatorSelectSetting {
5
-
6
-
const SETTINGKEY = 'multiedit';
7
-
8
-
const VALUE_SPACES = 'spaces';
9
-
const VALUE_SINGLE = 'disable';
10
-
11
-
public function getSettingName() {
12
-
return pht('Edit Multiple Files');
13
-
}
14
-
15
-
public function getSettingPanelKey() {
16
-
return PhabricatorExternalEditorSettingsPanel::PANELKEY;
17
-
}
18
-
19
-
protected function getSettingOrder() {
20
-
return 400;
21
-
}
22
-
23
-
protected function getControlInstructions() {
24
-
return pht(
25
-
'Some editors support opening multiple files with a single URI. You '.
26
-
'can specify the behavior of your editor here.');
27
-
}
28
-
29
-
public function getSettingDefaultValue() {
30
-
return self::VALUE_SPACES;
31
-
}
32
-
33
-
protected function getSelectOptions() {
34
-
return array(
35
-
self::VALUE_SPACES => pht('Supported, Separated by Spaces'),
36
-
self::VALUE_SINGLE => pht('Not Supported'),
37
-
);
38
-
}
39
-
40
-
}