recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where Harbormaster might cycle while saving

The way custom field interact with storage is a little odd, and can send us
down a bad path when applying external effect while saving changes.

epriestley 4169d7bf 43bee456

+7 -4
+1 -3
src/infrastructure/customfield/field/PhabricatorCustomField.php
··· 540 540 * @task storage 541 541 */ 542 542 public function newStorageObject() { 543 - if ($this->proxy) { 544 - return $this->proxy->newStorageObject(); 545 - } 543 + // NOTE: This intentionally isn't proxied, to avoid call cycles. 546 544 throw new PhabricatorCustomFieldImplementationIncompleteException($this); 547 545 } 548 546
+6 -1
src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
··· 186 186 } 187 187 188 188 public function shouldUseStorage() { 189 - return true; 189 + try { 190 + $object = $this->newStorageObject(); 191 + return true; 192 + } catch (PhabricatorCustomFieldImplementationIncompleteException $ex) { 193 + return false; 194 + } 190 195 } 191 196 192 197 public function getValueForStorage() {