recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Disable JSON shield for uncaught exception responses to Conduit requests

Summary: Modern conduit responses should never have a JSON shield. We disable it for normal responses, but uncaught exceptions hit this higher-level handler block which fails to disable the shield. Disable the shield.

Test Plan: Inspection.

Reviewers: btrahan, andrewjcg

Reviewed By: andrewjcg

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5483

epriestley 41b32d5f e80c59cb

+1
+1
src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
··· 137 137 $response->setErrorInfo($ex->getMessage()); 138 138 139 139 return id(new AphrontJSONResponse()) 140 + ->setAddJSONShield(false) 140 141 ->setContent($response->toDictionary()); 141 142 } 142 143