@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
render_tag -> tag: forms / remarkup
Summary: See inlines.
Test Plan: See inlines.
Reviewers: vrana
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4767
+26
-20
+8
-9
src/view/form/control/AphrontFormDateControl.php
+8
-9
src/view/form/control/AphrontFormDateControl.php
···
247
247
248
248
Javelin::initBehavior('fancy-datepicker', array());
249
249
250
-
return javelin_render_tag(
250
+
return javelin_tag(
251
251
'div',
252
252
array(
253
253
'class' => 'aphront-form-date-container',
254
254
'sigil' => 'phabricator-date-control',
255
255
),
256
-
self::renderSingleView(
257
-
array(
258
-
$days_sel,
259
-
$months_sel,
260
-
$years_sel,
261
-
$cal_icon,
262
-
$time_sel,
263
-
)));
256
+
array(
257
+
$days_sel,
258
+
$months_sel,
259
+
$years_sel,
260
+
$cal_icon,
261
+
$time_sel,
262
+
));
264
263
}
265
264
266
265
}
+2
-2
src/view/form/control/AphrontFormSelectControl.php
+2
-2
src/view/form/control/AphrontFormSelectControl.php
···
35
35
36
36
$option_tags = self::renderOptions($selected, $options);
37
37
38
-
return javelin_render_tag(
38
+
return javelin_tag(
39
39
'select',
40
40
$attrs,
41
-
implode("\n", $option_tags));
41
+
$option_tags);
42
42
}
43
43
44
44
private static function renderOptions($selected, array $options) {
+6
-3
src/view/form/control/PhabricatorRemarkupControl.php
+6
-3
src/view/form/control/PhabricatorRemarkupControl.php
···
142
142
$this->setCustomClass(
143
143
'remarkup-assist-textarea '.$monospaced_textareas_class);
144
144
145
-
return javelin_render_tag(
145
+
return javelin_tag(
146
146
'div',
147
147
array(
148
148
'sigil' => 'remarkup-assist-control',
149
149
),
150
-
$buttons.
151
-
parent::renderInput());
150
+
$this->renderHTMLView(
151
+
array(
152
+
$buttons,
153
+
parent::renderInput(),
154
+
)));
152
155
}
153
156
154
157
}
+2
-2
src/view/layout/PhabricatorPropertyListView.php
+2
-2
src/view/layout/PhabricatorPropertyListView.php
···
73
73
}
74
74
}
75
75
76
-
return phutil_render_tag(
76
+
return phutil_tag(
77
77
'div',
78
78
array(
79
79
'class' => 'phabricator-property-list-view',
80
80
),
81
-
$this->renderSingleView($items));
81
+
$this->renderHTMLView($items));
82
82
}
83
83
84
84
private function renderPropertyPart(array $part) {
+8
-4
src/view/widget/AphrontKeyboardShortcutsAvailableView.php
+8
-4
src/view/widget/AphrontKeyboardShortcutsAvailableView.php
···
3
3
final class AphrontKeyboardShortcutsAvailableView extends AphrontView {
4
4
5
5
public function render() {
6
-
return
7
-
'<div class="keyboard-shortcuts-available">'.
8
-
'Press <strong>?</strong> to show keyboard shortcuts.'.
9
-
'</div>';
6
+
return phutil_tag(
7
+
'div',
8
+
array(
9
+
'class' => 'keyboard-shortcuts-available',
10
+
),
11
+
pht(
12
+
'Press %s to show keyboard shortcuts.',
13
+
phutil_tag('strong', array(), '?')));
10
14
}
11
15
12
16
}