@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct the generation of "<th />" IDs on left-hand-side of image changesets
Summary:
Fixes T7682. The left-hand-side "<th />" row did not generate with the correct ID.
(I couldn't reproduce the exact issue described in T7682, but hovering comments on either side now works properly for me.)
Test Plan: {F4962479}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T7682
Differential Revision: https://secure.phabricator.com/D17926
+6
+6
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
+6
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
···
323
323
$new = $this->renderImageStage($new_file);
324
324
}
325
325
326
+
// If we don't have an explicit "vs" changeset, it's the left side of the
327
+
// "id" changeset.
328
+
if (!$vs) {
329
+
$vs = $id;
330
+
}
331
+
326
332
$html_old = array();
327
333
$html_new = array();
328
334
foreach ($this->getOldComments() as $on_line => $comment_group) {