@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue which could prevent blocking reviewers from being removed from revisions
Summary: Ref T11114. After evaluating typeahead tokens, we could process blocking reviewer removals incorrectly: we may get structures back.
Test Plan: Removed blocking reviewers from the web UI.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17163
+7
-1
+7
-1
src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
+7
-1
src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
···
24
24
// First, remove any reviewers we're getting rid of.
25
25
$rem = idx($value, '-', array());
26
26
$rem = $datasource->evaluateTokens($rem);
27
-
foreach ($rem as $phid) {
27
+
foreach ($rem as $spec) {
28
+
if (!is_array($spec)) {
29
+
$phid = $spec;
30
+
} else {
31
+
$phid = $spec['phid'];
32
+
}
33
+
28
34
unset($reviewers[$phid]);
29
35
}
30
36