@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Increase Drydock worker time to 24 hours
Summary:
Ref T2015. This increases the Drydock worker lease time to 24 hours. We noticed that some leases took longer than 2 hours when leasing from AWS (the actual resource was successfully leased at around 2 hours, 19 minutes).
24 hours should be plenty enough time to actually lease anything from EC2 (or any other leases during builds).
Test Plan: Have not yet tested this.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T2015
Differential Revision: https://secure.phabricator.com/D10544
+4
+4
src/applications/drydock/worker/DrydockAllocatorWorker.php
+4
src/applications/drydock/worker/DrydockAllocatorWorker.php
···
4
4
5
5
private $lease;
6
6
7
+
public function getRequiredLeaseTime() {
8
+
return 3600 * 24;
9
+
}
10
+
7
11
public function getMaximumRetryCount() {
8
12
// TODO: Allow Drydock allocations to retry. For now, every failure is
9
13
// permanent and most of them are because I am bad at programming, so fail