@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some content/background overflow issues with commit graph lists
Summary: Ref T13552. There are currently some content overflow issues on the graph view where the menu height can exceed the content height and the frame is drawn on a sub-element. Make the frame draw around all the content.
Test Plan: Viewed commit graph history view, saw more sensible UI.
Maniphest Tasks: T13552
Differential Revision: https://secure.phabricator.com/D21440
+23
-22
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '0e3cf785',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => '2ffd6897',
12
+
'core.pkg.css' => 'b13bef94',
13
13
'core.pkg.js' => 'adc34883',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => '5c459f92',
···
137
137
'rsrc/css/phui/object-item/phui-oi-color.css' => 'b517bfa0',
138
138
'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'da15d3dc',
139
139
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '490e2e2e',
140
-
'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'ecd651d5',
140
+
'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'af98a277',
141
141
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => '6a30fa46',
142
142
'rsrc/css/phui/phui-action-list.css' => '1b0085b2',
143
143
'rsrc/css/phui/phui-action-panel.css' => '6c386cbf',
···
874
874
'phui-oi-color-css' => 'b517bfa0',
875
875
'phui-oi-drag-ui-css' => 'da15d3dc',
876
876
'phui-oi-flush-ui-css' => '490e2e2e',
877
-
'phui-oi-list-view-css' => 'ecd651d5',
877
+
'phui-oi-list-view-css' => 'af98a277',
878
878
'phui-oi-simple-ui-css' => '6a30fa46',
879
879
'phui-pager-css' => 'd022c7ad',
880
880
'phui-pinboard-view-css' => '1f08f5d8',
+18
-16
src/view/phui/PHUIObjectItemView.php
+18
-16
src/view/phui/PHUIObjectItemView.php
···
816
816
$box,
817
817
));
818
818
819
+
if ($this->menu) {
820
+
$grid_view = id(new FuelGridView())
821
+
->addClass('fuel-grid-tablet');
822
+
$grid_row = $grid_view->newRow();
823
+
824
+
$grid_row->newCell()
825
+
->setContent($frame_content);
826
+
827
+
$menu = $this->menu;
828
+
829
+
$grid_row->newCell()
830
+
->addClass('phui-oi-menu')
831
+
->setContent($menu);
832
+
833
+
$frame_content = $grid_view;
834
+
}
835
+
819
836
$frame_cover = null;
820
837
if ($this->coverImage) {
821
838
$cover_image = phutil_tag(
···
843
860
$frame_content,
844
861
));
845
862
846
-
$grid_view = id(new FuelGridView())
847
-
->addClass('fuel-grid-tablet');
848
-
$grid_row = $grid_view->newRow();
849
-
850
-
$grid_row->newCell()
851
-
->setContent($frame);
852
-
853
-
if ($this->menu) {
854
-
$menu = $this->menu;
855
-
856
-
$grid_row->newCell()
857
-
->addClass('phui-oi-menu')
858
-
->setContent($menu);
859
-
}
860
-
861
-
return $grid_view;
863
+
return $frame;
862
864
}
863
865
864
866
private function renderStatusIcon($icon, $label) {
+2
-3
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+2
-3
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
···
736
736
.device-desktop .phui-oi-menu,
737
737
.device-tablet .phui-oi-menu {
738
738
width: 200px;
739
-
border-width: 0 0 1px 1px;
739
+
border-width: 0 0 0 1px;
740
740
}
741
741
742
742
.device-phone .phui-oi-menu {
743
-
border-width: 0 0 1px;
744
-
margin-bottom: 12px;
743
+
border-width: 1px 0 0;
745
744
}