@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove all remaining readers and writers for TABLE_COMMIT
Summary: Depends on D20459. Ref T13276. I'll file a followup to actually destroy the table.
Test Plan:
- Grepped for `TABLE_COMMIT`.
- Ran `bin/storage upgrade -f`, got a clean bill of health.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13276
Differential Revision: https://secure.phabricator.com/D20461
+4
-16
-8
src/applications/differential/storage/DifferentialRevision.php
-8
src/applications/differential/storage/DifferentialRevision.php
···
53
53
private $flags = array();
54
54
private $forceMap = array();
55
55
56
-
const TABLE_COMMIT = 'differential_commit';
57
-
58
56
const RELATION_REVIEWER = 'revw';
59
57
const RELATION_SUBSCRIBED = 'subd';
60
58
···
1020
1018
}
1021
1019
1022
1020
$conn_w = $this->establishConnection('w');
1023
-
1024
-
queryfx(
1025
-
$conn_w,
1026
-
'DELETE FROM %T WHERE revisionID = %d',
1027
-
self::TABLE_COMMIT,
1028
-
$this->getID());
1029
1021
1030
1022
// we have to do paths a little differently as they do not have
1031
1023
// an id or phid column for delete() to act on
+4
-1
src/applications/differential/storage/DifferentialSchemaSpec.php
+4
-1
src/applications/differential/storage/DifferentialSchemaSpec.php
···
26
26
'persistence' => PhabricatorConfigTableSchema::PERSISTENCE_CACHE,
27
27
));
28
28
29
+
// TODO: All readers and writers for this table were removed in April
30
+
// 2019. Destroy this table once we're sure we won't miss it.
31
+
29
32
$this->buildRawSchema(
30
33
id(new DifferentialRevision())->getApplicationName(),
31
-
DifferentialRevision::TABLE_COMMIT,
34
+
'differential_commit',
32
35
array(
33
36
'revisionID' => 'id',
34
37
'commitPHID' => 'phid',
-7
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
-7
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
···
231
231
->addEdge($commit->getPHID(), $commit_drev, $revision->getPHID())
232
232
->save();
233
233
234
-
queryfx(
235
-
$conn_w,
236
-
'INSERT IGNORE INTO %T (revisionID, commitPHID) VALUES (%d, %s)',
237
-
DifferentialRevision::TABLE_COMMIT,
238
-
$revision->getID(),
239
-
$commit->getPHID());
240
-
241
234
$should_close = !$revision->isPublished() && $should_autoclose;
242
235
if ($should_close) {
243
236
$type_close = DifferentialRevisionCloseTransaction::TRANSACTIONTYPE;