@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use RemarkupControl in Differential inline comment UI
Summary: Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.
Test Plan: {F101825}
Reviewers: chad, btrahan
Reviewed By: chad
CC: chad, aran
Maniphest Tasks: T4317
Differential Revision: https://secure.phabricator.com/D7969
+7
-22
-11
src/applications/differential/view/DifferentialInlineCommentEditView.php
-11
src/applications/differential/view/DifferentialInlineCommentEditView.php
···
104
104
),
105
105
pht('Cancel'));
106
106
107
-
$formatting = phutil_tag(
108
-
'a',
109
-
array(
110
-
'href' => PhabricatorEnv::getDoclink(
111
-
'article/Remarkup_Reference.html'),
112
-
'tabindex' => '-1',
113
-
'target' => '_blank',
114
-
),
115
-
pht('Formatting Reference'));
116
-
117
107
$title = phutil_tag(
118
108
'div',
119
109
array(
···
134
124
'class' => 'differential-inline-comment-edit-buttons',
135
125
),
136
126
array(
137
-
$formatting,
138
127
$buttons,
139
128
phutil_tag('div', array('style' => 'clear: both'), ''),
140
129
));
+5
-8
src/infrastructure/diff/PhabricatorInlineCommentController.php
+5
-8
src/infrastructure/diff/PhabricatorInlineCommentController.php
···
235
235
}
236
236
237
237
private function renderTextArea($text) {
238
-
return javelin_tag(
239
-
'textarea',
240
-
array(
241
-
'class' => 'differential-inline-comment-edit-textarea',
242
-
'sigil' => 'differential-inline-comment-edit-textarea',
243
-
'name' => 'text',
244
-
),
245
-
$text);
238
+
return id(new PhabricatorRemarkupControl())
239
+
->setUser($this->getRequest()->getUser())
240
+
->setSigil('differential-inline-comment-edit-textarea')
241
+
->setName('text')
242
+
->setValue($text);
246
243
}
247
244
248
245
}
+2
-3
webroot/rsrc/css/application/differential/changeset-view.css
+2
-3
webroot/rsrc/css/application/differential/changeset-view.css