recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where Herald rules could fail to evaluate at post-commit time

Summary: Ref T13480. Some Herald fields need audit information, which recent changes to Herald adapters discarded. For now, just load it unconditionally.

Test Plan: Triggered an Audit-related rule locally.

Maniphest Tasks: T13480

Differential Revision: https://secure.phabricator.com/D20962

epriestley 42e46bbe ccf28a81

+1
+1
src/applications/diffusion/herald/HeraldCommitAdapter.php
··· 52 52 ->withPHIDs(array($commit_phid)) 53 53 ->needCommitData(true) 54 54 ->needIdentities(true) 55 + ->needAuditRequests(true) 55 56 ->executeOne(); 56 57 if (!$commit) { 57 58 throw new Exception(