recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Prevent crashes when more than one buildable for an object exists

Summary: This prevents a crash in applying build plans when more than one buildable exists for the same object. It also adds a check into the "New Manual Build" page to ensure that users can't create a buildable for an object that already has one.

Test Plan: Tried to create a buildable for an object that already has one and a nice friendly error appeared. Applied a build plan to a buildable whose object has two buildables and didn't get a crash any more.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7543

authored by

James Rhodes and committed by
epriestley 43847d6b aca621e2

+1
+1
src/applications/harbormaster/storage/HarbormasterBuildable.php
··· 34 34 $buildable = id(new HarbormasterBuildableQuery()) 35 35 ->setViewer($actor) 36 36 ->withBuildablePHIDs(array($buildable_object_phid)) 37 + ->setLimit(1) 37 38 ->executeOne(); 38 39 if ($buildable) { 39 40 return $buildable;