@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix help menu links for folks with diviner uninstalled
Summary: move code to uninstallable help app rather than diviner. Fixes T4690.
Test Plan: uninstalled diviner, noted no links, then moved the code and suddenly helpful help links showed up once more.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T4690
Differential Revision: https://secure.phabricator.com/D8638
+24
-25
-25
src/applications/diviner/application/PhabricatorApplicationDiviner.php
-25
src/applications/diviner/application/PhabricatorApplicationDiviner.php
···
45
45
);
46
46
}
47
47
48
-
public function buildMainMenuItems(
49
-
PhabricatorUser $user,
50
-
PhabricatorController $controller = null) {
51
-
52
-
$items = array();
53
-
54
-
$application = null;
55
-
if ($controller) {
56
-
$application = $controller->getCurrentApplication();
57
-
}
58
-
59
-
if ($application && $application->getHelpURI()) {
60
-
$item = id(new PHUIListItemView())
61
-
->setName(pht('%s Help', $application->getName()))
62
-
->addClass('core-menu-item')
63
-
->setIcon('info-sm')
64
-
->setOrder(200)
65
-
->setHref($application->getHelpURI());
66
-
$items[] = $item;
67
-
}
68
-
69
-
return $items;
70
-
}
71
-
72
-
73
48
}
+24
src/applications/help/application/PhabricatorApplicationHelp.php
+24
src/applications/help/application/PhabricatorApplicationHelp.php
···
19
19
);
20
20
}
21
21
22
+
public function buildMainMenuItems(
23
+
PhabricatorUser $user,
24
+
PhabricatorController $controller = null) {
25
+
26
+
$items = array();
27
+
28
+
$application = null;
29
+
if ($controller) {
30
+
$application = $controller->getCurrentApplication();
31
+
}
32
+
33
+
if ($application && $application->getHelpURI()) {
34
+
$item = id(new PHUIListItemView())
35
+
->setName(pht('%s Help', $application->getName()))
36
+
->addClass('core-menu-item')
37
+
->setIcon('info-sm')
38
+
->setOrder(200)
39
+
->setHref($application->getHelpURI());
40
+
$items[] = $item;
41
+
}
42
+
43
+
return $items;
44
+
}
45
+
22
46
}