@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Include number of modified files in total of attached files
Summary:
The second parameter in the message `%s updated %s attached file(s), added %s: %s; removed %s: %s; modified %s: %s.` did not take the number of modified files into account but only added and removed files.
Closes T15959
Test Plan:
Read the code.
Additionally, update and remove and modify files attached to a task and count.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15959
Differential Revision: https://we.phorge.it/D25892
+1
-1
+1
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+1
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
1118
1118
'%s updated %s attached file(s), added %s: %s; removed %s: %s; '.
1119
1119
'modified %s: %s.',
1120
1120
$this->renderHandleLink($author_phid),
1121
-
new PhutilNumber(count($add) + count($rem)),
1121
+
new PhutilNumber(count($add) + count($rem) + count($mod)),
1122
1122
phutil_count($add),
1123
1123
$this->renderHandleList($add),
1124
1124
phutil_count($rem),