@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fail more softly on funky arcanist project / symbol data
Summary: Fixes T8240, probably?
Test Plan: This is hard to test locally post-migration -- @btrahan, does it fix things for you?
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: btrahan, epriestley
Maniphest Tasks: T8240
Differential Revision: https://secure.phabricator.com/D12903
+12
-2
+12
-2
resources/sql/autopatches/20150504.symbolsproject.1.php
+12
-2
resources/sql/autopatches/20150504.symbolsproject.1.php
···
38
38
idx($project_row, 'name', '???'));
39
39
40
40
$symbol_index_projects = $project_row['symbolIndexProjects'];
41
-
$symbol_index_projects = phutil_json_decode($symbol_index_projects);
41
+
$symbol_index_projects = nonempty($symbol_index_projects, '[]');
42
+
try {
43
+
$symbol_index_projects = phutil_json_decode($symbol_index_projects);
44
+
} catch (PhutilJSONParserException $ex) {
45
+
continue;
46
+
}
42
47
43
48
$sources = $repo->getDetail('symbol-sources', array());
44
49
foreach ($symbol_index_projects as $index_project) {
···
50
55
$repo->setDetail('symbol-sources', $sources);
51
56
52
57
$languages = $project_row['symbolIndexLanguages'];
53
-
$languages = phutil_json_decode($languages);
58
+
$languages = nonempty($languages, '[]');
59
+
try {
60
+
$languages = phutil_json_decode($languages);
61
+
} catch (PhutilJSONParserException $ex) {
62
+
continue;
63
+
}
54
64
55
65
$languages = array_merge(
56
66
$repo->getDetail('symbol-languages', array()),