+2 -2

src/applications/auth/query/PhabricatorExternalAccountQuery.php

reviewed

··· 62 62 return $this; 63 63 } 64 64 65 65 - public function loadPage() { 65 65 + protected function loadPage() { 66 66 $table = new PhabricatorExternalAccount(); 67 67 $conn_r = $table->establishConnection('r'); 68 68 ··· 77 77 return $table->loadAllFromArray($data); 78 78 } 79 79 80 80 - public function willFilterPage(array $accounts) { 80 80 + protected function willFilterPage(array $accounts) { 81 81 if ($this->needImages) { 82 82 $file_phids = mpull($accounts, 'getProfileImagePHID'); 83 83 $file_phids = array_filter($file_phids);

+1 -1

src/applications/chatlog/query/PhabricatorChatLogQuery.php

reviewed

··· 33 33 return $logs; 34 34 } 35 35 36 36 - public function willFilterPage(array $events) { 36 36 + protected function willFilterPage(array $events) { 37 37 $channel_ids = mpull($events, 'getChannelID', 'getChannelID'); 38 38 39 39 $channels = id(new PhabricatorChatLogChannelQuery())

+1 -1

src/applications/conduit/query/PhabricatorConduitLogQuery.php

reviewed

··· 10 10 return $this; 11 11 } 12 12 13 13 - public function loadPage() { 13 13 + protected function loadPage() { 14 14 $table = new PhabricatorConduitMethodCallLog(); 15 15 $conn_r = $table->establishConnection('r'); 16 16

+1 -1

src/applications/conduit/query/PhabricatorConduitMethodQuery.php

reviewed

··· 40 40 return $this; 41 41 } 42 42 43 43 - public function loadPage() { 43 43 + protected function loadPage() { 44 44 $methods = $this->getAllMethods(); 45 45 $methods = $this->filterMethods($methods); 46 46 return $methods;

+1 -1

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

reviewed

··· 34 34 return $this; 35 35 } 36 36 37 37 - public function loadPage() { 37 37 + protected function loadPage() { 38 38 $table = new PhabricatorConduitToken(); 39 39 $conn_r = $table->establishConnection('r'); 40 40

+1 -1

src/applications/config/query/PhabricatorConfigEntryQuery.php

reviewed

··· 16 16 return $this; 17 17 } 18 18 19 19 - public function loadPage() { 19 19 + protected function loadPage() { 20 20 $table = new PhabricatorConfigEntry(); 21 21 $conn_r = $table->establishConnection('r'); 22 22

+2 -2

src/applications/daemon/query/PhabricatorDaemonLogQuery.php

reviewed

··· 45 45 return $this; 46 46 } 47 47 48 48 - public function loadPage() { 48 48 + protected function loadPage() { 49 49 $table = new PhabricatorDaemonLog(); 50 50 $conn_r = $table->establishConnection('r'); 51 51 ··· 60 60 return $table->loadAllFromArray($data); 61 61 } 62 62 63 63 - public function willFilterPage(array $daemons) { 63 63 + protected function willFilterPage(array $daemons) { 64 64 $unknown_delay = PhabricatorDaemonLogQuery::getTimeUntilUnknown(); 65 65 $dead_delay = PhabricatorDaemonLogQuery::getTimeUntilDead(); 66 66

+4 -4

src/applications/differential/query/DifferentialChangesetQuery.php

reviewed

··· 30 30 return $this; 31 31 } 32 32 33 33 - public function willExecute() { 33 33 + protected function willExecute() { 34 34 // If we fail to load any changesets (which is possible in the case of an 35 35 // empty commit) we'll never call didFilterPage(). Attach empty changeset 36 36 // lists now so that we end up with the right result. ··· 41 41 } 42 42 } 43 43 44 44 - public function loadPage() { 44 44 + protected function loadPage() { 45 45 $table = new DifferentialChangeset(); 46 46 $conn_r = $table->establishConnection('r'); 47 47 ··· 56 56 return $table->loadAllFromArray($data); 57 57 } 58 58 59 59 - public function willFilterPage(array $changesets) { 59 59 + protected function willFilterPage(array $changesets) { 60 60 // First, attach all the diffs we already have. We can just do this 61 61 // directly without worrying about querying for them. When we don't have 62 62 // a diff, record that we need to load it. ··· 103 103 return $changesets; 104 104 } 105 105 106 106 - public function didFilterPage(array $changesets) { 106 106 + protected function didFilterPage(array $changesets) { 107 107 if ($this->needAttachToDiffs) { 108 108 $changeset_groups = mgroup($changesets, 'getDiffID'); 109 109 foreach ($this->diffs as $diff) {

+2 -2

src/applications/differential/query/DifferentialDiffQuery.php

reviewed

··· 34 34 return $this; 35 35 } 36 36 37 37 - public function loadPage() { 37 37 + protected function loadPage() { 38 38 $table = new DifferentialDiff(); 39 39 $conn_r = $table->establishConnection('r'); 40 40 ··· 49 49 return $table->loadAllFromArray($data); 50 50 } 51 51 52 52 - public function willFilterPage(array $diffs) { 52 52 + protected function willFilterPage(array $diffs) { 53 53 $revision_ids = array_filter(mpull($diffs, 'getRevisionID')); 54 54 55 55 $revisions = array();

+4 -4

src/applications/differential/query/DifferentialHunkQuery.php

reviewed

··· 17 17 return $this; 18 18 } 19 19 20 20 - public function willExecute() { 20 20 + protected function willExecute() { 21 21 // If we fail to load any hunks at all (for example, because all of 22 22 // the requested changesets are directories or empty files and have no 23 23 // hunks) we'll never call didFilterPage(), and thus never have an ··· 30 30 } 31 31 } 32 32 33 33 - public function loadPage() { 33 33 + protected function loadPage() { 34 34 $all_results = array(); 35 35 36 36 // Load modern hunks. ··· 65 65 return array_values(array_merge($legacy_results, $modern_results)); 66 66 } 67 67 68 68 - public function willFilterPage(array $hunks) { 68 68 + protected function willFilterPage(array $hunks) { 69 69 $changesets = mpull($this->changesets, null, 'getID'); 70 70 foreach ($hunks as $key => $hunk) { 71 71 $changeset = idx($changesets, $hunk->getChangesetID()); ··· 78 78 return $hunks; 79 79 } 80 80 81 81 - public function didFilterPage(array $hunks) { 81 81 + protected function didFilterPage(array $hunks) { 82 82 if ($this->shouldAttachToChangesets) { 83 83 $hunk_groups = mgroup($hunks, 'getChangesetID'); 84 84 foreach ($this->changesets as $changeset) {

+2 -2

src/applications/differential/query/DifferentialRevisionQuery.php

reviewed

··· 368 368 * @return list List of matching DifferentialRevision objects. 369 369 * @task exec 370 370 */ 371 371 - public function loadPage() { 371 371 + protected function loadPage() { 372 372 $table = new DifferentialRevision(); 373 373 $conn_r = $table->establishConnection('r'); 374 374 ··· 377 377 return $table->loadAllFromArray($data); 378 378 } 379 379 380 380 - public function willFilterPage(array $revisions) { 380 380 + protected function willFilterPage(array $revisions) { 381 381 $viewer = $this->getViewer(); 382 382 383 383 $repository_phids = mpull($revisions, 'getRepositoryPHID');

+1 -1

src/applications/diffusion/query/DiffusionCommitQuery.php

reviewed

··· 501 501 return $this->formatWhereClause($where); 502 502 } 503 503 504 504 - public function didFilterResults(array $filtered) { 504 504 + protected function didFilterResults(array $filtered) { 505 505 if ($this->identifierMap) { 506 506 foreach ($this->identifierMap as $name => $commit) { 507 507 if (isset($filtered[$commit->getPHID()])) {

+1 -1

src/applications/doorkeeper/query/DoorkeeperExternalObjectQuery.php

reviewed

··· 16 16 return $this; 17 17 } 18 18 19 19 - public function loadPage() { 19 19 + protected function loadPage() { 20 20 $table = new DoorkeeperExternalObject(); 21 21 $conn_r = $table->establishConnection('r'); 22 22

+1 -1

src/applications/drydock/query/DrydockBlueprintQuery.php

reviewed

··· 15 15 return $this; 16 16 } 17 17 18 18 - public function loadPage() { 18 18 + protected function loadPage() { 19 19 $table = new DrydockBlueprint(); 20 20 $conn_r = $table->establishConnection('r'); 21 21

+2 -2

src/applications/drydock/query/DrydockLeaseQuery.php

reviewed

··· 27 27 return $this; 28 28 } 29 29 30 30 - public function loadPage() { 30 30 + protected function loadPage() { 31 31 $table = new DrydockLease(); 32 32 $conn_r = $table->establishConnection('r'); 33 33 ··· 42 42 return $table->loadAllFromArray($data); 43 43 } 44 44 45 45 - public function willFilterPage(array $leases) { 45 45 + protected function willFilterPage(array $leases) { 46 46 $resource_ids = array_filter(mpull($leases, 'getResourceID')); 47 47 if ($resource_ids) { 48 48 $resources = id(new DrydockResourceQuery())

+2 -2

src/applications/drydock/query/DrydockLogQuery.php

reviewed

··· 15 15 return $this; 16 16 } 17 17 18 18 - public function loadPage() { 18 18 + protected function loadPage() { 19 19 $table = new DrydockLog(); 20 20 $conn_r = $table->establishConnection('r'); 21 21 ··· 30 30 return $table->loadAllFromArray($data); 31 31 } 32 32 33 33 - public function willFilterPage(array $logs) { 33 33 + protected function willFilterPage(array $logs) { 34 34 $resource_ids = array_filter(mpull($logs, 'getResourceID')); 35 35 if ($resource_ids) { 36 36 $resources = id(new DrydockResourceQuery())

+1 -1

src/applications/drydock/query/DrydockResourceQuery.php

reviewed

··· 33 33 return $this; 34 34 } 35 35 36 36 - public function loadPage() { 36 36 + protected function loadPage() { 37 37 $table = new DrydockResource(); 38 38 $conn_r = $table->establishConnection('r'); 39 39

+2 -2

src/applications/flag/query/PhabricatorFlagQuery.php

reviewed

··· 65 65 ->executeOne(); 66 66 } 67 67 68 68 - public function loadPage() { 68 68 + protected function loadPage() { 69 69 $table = new PhabricatorFlag(); 70 70 $conn_r = $table->establishConnection('r'); 71 71 ··· 80 80 return $table->loadAllFromArray($data); 81 81 } 82 82 83 83 - public function willFilterPage(array $flags) { 83 83 + protected function willFilterPage(array $flags) { 84 84 if ($this->needObjects) { 85 85 $objects = id(new PhabricatorObjectQuery()) 86 86 ->setViewer($this->getViewer())

+2 -2

src/applications/herald/query/HeraldRuleQuery.php

reviewed

··· 69 69 return $this; 70 70 } 71 71 72 72 - public function loadPage() { 72 72 + protected function loadPage() { 73 73 $table = new HeraldRule(); 74 74 $conn_r = $table->establishConnection('r'); 75 75 ··· 84 84 return $table->loadAllFromArray($data); 85 85 } 86 86 87 87 - public function willFilterPage(array $rules) { 87 87 + protected function willFilterPage(array $rules) { 88 88 $rule_ids = mpull($rules, 'getID'); 89 89 90 90 // Filter out any rules that have invalid adapters, or have adapters the

+2 -2

src/applications/herald/query/HeraldTranscriptQuery.php

reviewed

··· 22 22 return $this; 23 23 } 24 24 25 25 - public function loadPage() { 25 25 + protected function loadPage() { 26 26 $transcript = new HeraldTranscript(); 27 27 $conn_r = $transcript->establishConnection('r'); 28 28 ··· 67 67 return $transcripts; 68 68 } 69 69 70 70 - public function willFilterPage(array $transcripts) { 70 70 + protected function willFilterPage(array $transcripts) { 71 71 $phids = mpull($transcripts, 'getObjectPHID'); 72 72 73 73 $objects = id(new PhabricatorObjectQuery())

+1 -1

src/applications/mailinglists/query/PhabricatorMailingListQuery.php

reviewed

··· 28 28 return $this; 29 29 } 30 30 31 31 - public function loadPage() { 31 31 + protected function loadPage() { 32 32 $table = new PhabricatorMetaMTAMailingList(); 33 33 $conn_r = $table->establishConnection('r'); 34 34

+1 -1

src/applications/maniphest/query/ManiphestTaskQuery.php

reviewed

··· 222 222 return $this; 223 223 } 224 224 225 225 - public function loadPage() { 225 225 + protected function loadPage() { 226 226 // TODO: (T603) It is possible for a user to find the PHID of a project 227 227 // they can't see, then query for tasks in that project and deduce the 228 228 // identity of unknown/invisible projects. Before we allow the user to

+1 -1

src/applications/meta/query/PhabricatorApplicationQuery.php

reviewed

··· 62 62 return $this; 63 63 } 64 64 65 65 - public function loadPage() { 65 65 + protected function loadPage() { 66 66 $apps = PhabricatorApplication::getAllApplications(); 67 67 68 68 if ($this->classes) {

+1 -1

src/applications/nuance/query/NuanceItemQuery.php

reviewed

··· 23 23 } 24 24 25 25 26 26 - public function loadPage() { 26 26 + protected function loadPage() { 27 27 $table = new NuanceItem(); 28 28 $conn_r = $table->establishConnection('r'); 29 29

+1 -1

src/applications/nuance/query/NuanceQueueQuery.php

reviewed

··· 16 16 return $this; 17 17 } 18 18 19 19 - public function loadPage() { 19 19 + protected function loadPage() { 20 20 $table = new NuanceQueue(); 21 21 $conn_r = $table->establishConnection('r'); 22 22

+1 -1

src/applications/nuance/query/NuanceRequestorQuery.php

reviewed

··· 16 16 return $this; 17 17 } 18 18 19 19 - public function loadPage() { 19 19 + protected function loadPage() { 20 20 $table = new NuanceRequestor(); 21 21 $conn_r = $table->establishConnection('r'); 22 22

+1 -1

src/applications/nuance/query/NuanceSourceQuery.php

reviewed

··· 29 29 } 30 30 31 31 32 32 - public function loadPage() { 32 32 + protected function loadPage() { 33 33 $table = new NuanceSource(); 34 34 $conn_r = $table->establishConnection('r'); 35 35

+2 -2

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

reviewed

··· 22 22 return $this; 23 23 } 24 24 25 25 - public function loadPage() { 25 25 + protected function loadPage() { 26 26 $table = new PhabricatorOAuthClientAuthorization(); 27 27 $conn_r = $table->establishConnection('r'); 28 28 ··· 37 37 return $table->loadAllFromArray($data); 38 38 } 39 39 40 40 - public function willFilterPage(array $authorizations) { 40 40 + protected function willFilterPage(array $authorizations) { 41 41 $client_phids = mpull($authorizations, 'getClientPHID'); 42 42 43 43 $clients = id(new PhabricatorOAuthServerClientQuery())

+1 -1

src/applications/oauthserver/query/PhabricatorOAuthServerClientQuery.php

reviewed

··· 22 22 return $this; 23 23 } 24 24 25 25 - public function loadPage() { 25 25 + protected function loadPage() { 26 26 $table = new PhabricatorOAuthServerClient(); 27 27 $conn_r = $table->establishConnection('r'); 28 28

+1 -1

src/applications/people/query/PhabricatorPeopleLogQuery.php

reviewed

··· 40 40 return $this; 41 41 } 42 42 43 43 - public function loadPage() { 43 43 + protected function loadPage() { 44 44 $table = new PhabricatorUserLog(); 45 45 $conn_r = $table->establishConnection('r'); 46 46

+1 -1

src/applications/people/query/PhabricatorPeopleQuery.php

reviewed

··· 101 101 return $this; 102 102 } 103 103 104 104 - public function loadPage() { 104 104 + protected function loadPage() { 105 105 $table = new PhabricatorUser(); 106 106 $conn_r = $table->establishConnection('r'); 107 107

+1 -1

src/applications/phid/query/PhabricatorHandleQuery.php

reviewed

··· 10 10 return $this; 11 11 } 12 12 13 13 - public function loadPage() { 13 13 + protected function loadPage() { 14 14 $types = PhabricatorPHIDType::getAllTypes(); 15 15 16 16 $phids = array_unique($this->phids);

+1 -1

src/applications/phid/query/PhabricatorObjectQuery.php

reviewed

··· 24 24 return $this; 25 25 } 26 26 27 27 - public function loadPage() { 27 27 + protected function loadPage() { 28 28 if ($this->namedResults === null) { 29 29 $this->namedResults = array(); 30 30 }

+1 -1

src/applications/phragment/query/PhragmentFragmentQuery.php

reviewed

··· 40 40 return $this; 41 41 } 42 42 43 43 - public function loadPage() { 43 43 + protected function loadPage() { 44 44 $table = new PhragmentFragment(); 45 45 $conn_r = $table->establishConnection('r'); 46 46

+1 -1

src/applications/phragment/query/PhragmentFragmentVersionQuery.php

reviewed

··· 34 34 return $this; 35 35 } 36 36 37 37 - public function loadPage() { 37 37 + protected function loadPage() { 38 38 $table = new PhragmentFragmentVersion(); 39 39 $conn_r = $table->establishConnection('r'); 40 40

+1 -1

src/applications/phragment/query/PhragmentSnapshotChildQuery.php

reviewed

··· 40 40 return $this; 41 41 } 42 42 43 43 - public function loadPage() { 43 43 + protected function loadPage() { 44 44 $table = new PhragmentSnapshotChild(); 45 45 $conn_r = $table->establishConnection('r'); 46 46

+1 -1

src/applications/phragment/query/PhragmentSnapshotQuery.php

reviewed

··· 28 28 return $this; 29 29 } 30 30 31 31 - public function loadPage() { 31 31 + protected function loadPage() { 32 32 $table = new PhragmentSnapshot(); 33 33 $conn_r = $table->establishConnection('r'); 34 34

+1 -1

src/applications/policy/__tests__/PhabricatorPolicyAwareTestQuery.php

reviewed

··· 29 29 } 30 30 } 31 31 32 32 - public function nextPage(array $page) { 32 32 + protected function nextPage(array $page) { 33 33 $this->offset += count($page); 34 34 } 35 35

+1 -1

src/applications/policy/query/PhabricatorPolicyQuery.php

reviewed

··· 53 53 return $policies; 54 54 } 55 55 56 56 - public function loadPage() { 56 56 + protected function loadPage() { 57 57 if ($this->object && $this->phids) { 58 58 throw new Exception( 59 59 'You can not issue a policy query with both setObject() and '.

+2 -2

src/applications/ponder/query/PonderAnswerQuery.php

reviewed

··· 65 65 return $this->formatWhereClause($where); 66 66 } 67 67 68 68 - public function loadPage() { 68 68 + protected function loadPage() { 69 69 $answer = new PonderAnswer(); 70 70 $conn_r = $answer->establishConnection('r'); 71 71 ··· 80 80 return $answer->loadAllFromArray($data); 81 81 } 82 82 83 83 - public function willFilterPage(array $answers) { 83 83 + protected function willFilterPage(array $answers) { 84 84 $questions = id(new PonderQuestionQuery()) 85 85 ->setViewer($this->getViewer()) 86 86 ->withIDs(mpull($answers, 'getQuestionID'))

+1 -1

src/applications/ponder/query/PonderQuestionQuery.php

reviewed

··· 137 137 return $question->loadAllFromArray($data); 138 138 } 139 139 140 140 - public function willFilterPage(array $questions) { 140 140 + protected function willFilterPage(array $questions) { 141 141 if ($this->needAnswers) { 142 142 $aquery = id(new PonderAnswerQuery()) 143 143 ->setViewer($this->getViewer())

+3 -3

src/applications/releeph/query/ReleephBranchQuery.php

reviewed

··· 39 39 return $this; 40 40 } 41 41 42 42 - public function loadPage() { 42 42 + protected function loadPage() { 43 43 $table = new ReleephBranch(); 44 44 $conn_r = $table->establishConnection('r'); 45 45 ··· 54 54 return $table->loadAllFromArray($data); 55 55 } 56 56 57 57 - public function willExecute() { 57 57 + protected function willExecute() { 58 58 if ($this->productPHIDs !== null) { 59 59 $products = id(new ReleephProductQuery()) 60 60 ->setViewer($this->getViewer()) ··· 69 69 } 70 70 } 71 71 72 72 - public function willFilterPage(array $branches) { 72 72 + protected function willFilterPage(array $branches) { 73 73 $project_ids = mpull($branches, 'getReleephProjectID'); 74 74 75 75 $projects = id(new ReleephProductQuery())

+3 -3

src/applications/releeph/query/ReleephProductQuery.php

reviewed

··· 44 44 return $this; 45 45 } 46 46 47 47 - public function loadPage() { 47 47 + protected function loadPage() { 48 48 $table = new ReleephProject(); 49 49 $conn_r = $table->establishConnection('r'); 50 50 ··· 59 59 return $table->loadAllFromArray($rows); 60 60 } 61 61 62 62 - public function willFilterPage(array $projects) { 62 62 + protected function willFilterPage(array $projects) { 63 63 assert_instances_of($projects, 'ReleephProject'); 64 64 65 65 $repository_phids = mpull($projects, 'getRepositoryPHID'); ··· 82 82 return $projects; 83 83 } 84 84 85 85 - public function didFilterPage(array $products) { 85 85 + protected function didFilterPage(array $products) { 86 86 if ($this->needArcanistProjects) { 87 87 $project_ids = array_filter(mpull($products, 'getArcanistProjectID')); 88 88 if ($project_ids) {

+2 -2

src/applications/releeph/query/ReleephRequestQuery.php

reviewed

··· 63 63 return $this; 64 64 } 65 65 66 66 - public function loadPage() { 66 66 + protected function loadPage() { 67 67 $table = new ReleephRequest(); 68 68 $conn_r = $table->establishConnection('r'); 69 69 ··· 78 78 return $table->loadAllFromArray($data); 79 79 } 80 80 81 81 - public function willFilterPage(array $requests) { 81 81 + protected function willFilterPage(array $requests) { 82 82 // Load requested objects: you must be able to see an object to see 83 83 // requests for it. 84 84 $object_phids = mpull($requests, 'getRequestedObjectPHID');

+1 -1

src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php

reviewed

··· 38 38 return $table->loadAllFromArray($data); 39 39 } 40 40 41 41 - public function willFilterPage(array $projects) { 41 41 + protected function willFilterPage(array $projects) { 42 42 assert_instances_of($projects, 'PhabricatorRepositoryArcanistProject'); 43 43 44 44 if ($this->needRepositories) {

+1 -1

src/applications/repository/query/PhabricatorRepositoryMirrorQuery.php

reviewed

··· 37 37 return $table->loadAllFromArray($data); 38 38 } 39 39 40 40 - public function willFilterPage(array $mirrors) { 40 40 + protected function willFilterPage(array $mirrors) { 41 41 assert_instances_of($mirrors, 'PhabricatorRepositoryMirror'); 42 42 43 43 $repository_phids = mpull($mirrors, 'getRepositoryPHID');

+2 -2

src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php

reviewed

··· 49 49 return $table->loadAllFromArray($data); 50 50 } 51 51 52 52 - public function willFilterPage(array $events) { 52 52 + protected function willFilterPage(array $events) { 53 53 $repository_phids = mpull($events, 'getRepositoryPHID'); 54 54 $repositories = id(new PhabricatorRepositoryQuery()) 55 55 ->setViewer($this->getViewer()) ··· 69 69 return $events; 70 70 } 71 71 72 72 - public function didFilterPage(array $events) { 72 72 + protected function didFilterPage(array $events) { 73 73 $phids = mpull($events, 'getPHID'); 74 74 75 75 if ($this->needLogs) {

+1 -1

src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php

reviewed

··· 61 61 return $table->loadAllFromArray($data); 62 62 } 63 63 64 64 - public function willFilterPage(array $logs) { 64 64 + protected function willFilterPage(array $logs) { 65 65 $event_phids = mpull($logs, 'getPushEventPHID'); 66 66 $events = id(new PhabricatorObjectQuery()) 67 67 ->setParentQuery($this)

+3 -3

src/applications/repository/query/PhabricatorRepositoryQuery.php

reviewed

··· 186 186 return $repositories; 187 187 } 188 188 189 189 - public function willFilterPage(array $repositories) { 189 189 + protected function willFilterPage(array $repositories) { 190 190 assert_instances_of($repositories, 'PhabricatorRepository'); 191 191 192 192 // TODO: Denormalize repository status into the PhabricatorRepository ··· 273 273 return $repositories; 274 274 } 275 275 276 276 - public function didFilterPage(array $repositories) { 276 276 + protected function didFilterPage(array $repositories) { 277 277 if ($this->needProjectPHIDs) { 278 278 $type_project = PhabricatorProjectObjectHasProjectEdgeType::EDGECONST; 279 279 ··· 294 294 return $repositories; 295 295 } 296 296 297 297 - public function getReversePaging() { 297 297 + protected function getReversePaging() { 298 298 switch ($this->order) { 299 299 case self::ORDER_CALLSIGN: 300 300 case self::ORDER_NAME:

+1 -1

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

reviewed

··· 37 37 return $table->loadAllFromArray($data); 38 38 } 39 39 40 40 - public function willFilterPage(array $refs) { 40 40 + protected function willFilterPage(array $refs) { 41 41 $repository_phids = mpull($refs, 'getRepositoryPHID'); 42 42 43 43 $repositories = id(new PhabricatorRepositoryQuery())

+2 -2

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

reviewed

··· 53 53 return $this; 54 54 } 55 55 56 56 - public function loadPage() { 56 56 + protected function loadPage() { 57 57 $table = new PhabricatorSlowvotePoll(); 58 58 $conn_r = $table->establishConnection('r'); 59 59 ··· 69 69 return $table->loadAllFromArray($data); 70 70 } 71 71 72 72 - public function willFilterPage(array $polls) { 72 72 + protected function willFilterPage(array $polls) { 73 73 assert_instances_of($polls, 'PhabricatorSlowvotePoll'); 74 74 75 75 $ids = mpull($polls, 'getID');

+1 -1

src/applications/tokens/query/PhabricatorTokenGivenQuery.php

reviewed

··· 66 66 return $this->formatWhereClause($where); 67 67 } 68 68 69 69 - public function willFilterPage(array $results) { 69 69 + protected function willFilterPage(array $results) { 70 70 $object_phids = array_filter(mpull($results, 'getObjectPHID')); 71 71 if (!$object_phids) { 72 72 return array();

+1 -1

src/applications/tokens/query/PhabricatorTokenReceiverQuery.php

reviewed

··· 18 18 return ipull($rows, 'objectPHID'); 19 19 } 20 20 21 21 - public function willFilterPage(array $phids) { 21 21 + protected function willFilterPage(array $phids) { 22 22 $objects = id(new PhabricatorObjectQuery()) 23 23 ->setViewer($this->getViewer()) 24 24 ->withPHIDs($phids)