recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Display each setting's config source on All Settings page

Summary:
As an admin, I want to understand which setting is loaded from which configuration source in order to better sync our staging and production instances of Phorge and e.g. transfer useful settings from the Database or Local Source to the Config File source shared between instances.
This is much easier when the config source for a setting is shown in the list of All Settings instead of being buried on each subpage.

Closes T16319

Test Plan:
Go to http://phorge.localhost/config/settings/all/ and look at the column on the right
Open a setting and verify that the source which was displayed in the list is the same as under "Current Configuration"

Reviewers: O1 Blessed Committers, mainframe98, avivey

Reviewed By: O1 Blessed Committers, mainframe98, avivey

Subscribers: avivey, mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16319

Differential Revision: https://we.phorge.it/D26452

Andre Klapper 46487c8c 2970a3df

+13
+13
src/applications/config/controller/settings/PhabricatorConfigSettingsListController.php
··· 79 79 80 80 $summary = $option->getSummary(); 81 81 82 + $stack = PhabricatorEnv::getConfigSourceStack(); 83 + $stack = $stack->getStack(); 84 + $key = $option->getKey(); 85 + $byline = null; 86 + foreach ($stack as $source) { 87 + $value = $source->getKeys(array($key)); 88 + if ($value) { 89 + $byline = $source->getName(); 90 + break; 91 + } 92 + } 93 + 82 94 $item = id(new PHUIObjectItemView()) 83 95 ->setHeader($option->getKey()) 84 96 ->setClickable(true) 97 + ->addByline($byline) 85 98 ->setHref('/config/edit/'.$option->getKey().'/') 86 99 ->addAttribute($summary); 87 100