recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix Diffusion crash

Summary: This fixes a crash that happens when visiting Diffusion pages due to an undefined variable. `$title` is only defined if it has a status to show, but then it uses it anyway and fails.

Test Plan: Pages stopped crashing and people stopped complaining.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8906

authored by

James Rhodes and committed by
epriestley 466af331 31580f19

+1
+1
src/applications/diffusion/controller/DiffusionController.php
··· 255 255 256 256 private function buildRepositoryWarning(PhabricatorRepository $repository) { 257 257 $error_view = null; 258 + $title = null; 258 259 if ($repository->isImporting()) { 259 260 $title = pht('This repository is still importing.'); 260 261 $body = pht('Things may not work properly until the import finishes.');