@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Have DifferentialRevisionList return an ObjectBox if header is set
Summary: Moving towards a consisent 'if header, show in object box' style around Phabricator.
Test Plan:
Grep for uses of RevisionList and make sure double boxes arent set, browse Differential, various searches, a revision, and a commit.
{F282113}
{F282114}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11651
+19
-10
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '8be366b7',
10
+
'core.pkg.css' => 'adb53fe7',
11
11
'core.pkg.js' => '65e04767',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '8af45893',
···
137
137
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
138
138
'rsrc/css/phui/phui-list.css' => '53deb25c',
139
139
'rsrc/css/phui/phui-object-box.css' => 'b8b7fd78',
140
-
'rsrc/css/phui/phui-object-item-list-view.css' => '2670a4a9',
140
+
'rsrc/css/phui/phui-object-item-list-view.css' => 'ace03f3e',
141
141
'rsrc/css/phui/phui-pinboard-view.css' => '3dd4a269',
142
142
'rsrc/css/phui/phui-property-list-view.css' => '51480060',
143
143
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
···
785
785
'phui-info-panel-css' => '27ea50a1',
786
786
'phui-list-view-css' => '53deb25c',
787
787
'phui-object-box-css' => 'b8b7fd78',
788
-
'phui-object-item-list-view-css' => '2670a4a9',
788
+
'phui-object-item-list-view-css' => 'ace03f3e',
789
789
'phui-pinboard-view-css' => '3dd4a269',
790
790
'phui-property-list-view-css' => '51480060',
791
791
'phui-remarkup-preview-css' => '19ad512b',
+2
-3
src/applications/differential/controller/DifferentialRevisionViewController.php
+2
-3
src/applications/differential/controller/DifferentialRevisionViewController.php
···
778
778
$user = $this->getRequest()->getUser();
779
779
780
780
$view = id(new DifferentialRevisionListView())
781
+
->setHeader(pht('Open Revisions Affecting These Files'))
781
782
->setRevisions($revisions)
782
783
->setUser($user);
783
784
···
785
786
$handles = $this->loadViewerHandles($phids);
786
787
$view->setHandles($handles);
787
788
788
-
return id(new PHUIObjectBoxView())
789
-
->setHeaderText(pht('Open Revisions Affecting These Files'))
790
-
->appendChild($view);
789
+
return $view;
791
790
}
792
791
793
792
+8
-1
src/applications/differential/view/DifferentialRevisionListView.php
+8
-1
src/applications/differential/view/DifferentialRevisionListView.php
···
179
179
$list->addItem($item);
180
180
}
181
181
182
-
$list->setHeader($this->header);
183
182
$list->setNoDataString($this->noDataString);
183
+
184
+
185
+
if ($this->header) {
186
+
$list->setFlush(true);
187
+
$list = id(new PHUIObjectBoxView())
188
+
->setHeaderText($this->header)
189
+
->appendChild($list);
190
+
}
184
191
185
192
return $list;
186
193
}
+2
-3
src/applications/diffusion/controller/DiffusionBrowseController.php
+2
-3
src/applications/diffusion/controller/DiffusionBrowseController.php
···
208
208
}
209
209
210
210
$view = id(new DifferentialRevisionListView())
211
+
->setHeader(pht('Pending Differential Revisions'))
211
212
->setRevisions($revisions)
212
213
->setUser($user);
213
214
···
215
216
$handles = $this->loadViewerHandles($phids);
216
217
$view->setHandles($handles);
217
218
218
-
return id(new PHUIObjectBoxView())
219
-
->setHeaderText(pht('Pending Differential Revisions'))
220
-
->appendChild($view);
219
+
return $view;
221
220
}
222
221
223
222
}