recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

When draft inline comments are submitted, disengage the editor

Summary:
Ref T13513. If you submit top-level comments while an inline comment editor is open, kick the comment out of the editing state.

(An improvement to this behavior would be to warn the user that we're going to do this first, but this is currently less straightforward.)

Test Plan:
- Clicked a line number to create an inline.
- Type text, save, click edit.
- (Optional: reload page.)
- Save changes overall using the form at the bottom of the page.
- Outcome: published inline is no longer in an "editing" state.

Weirdness:

- If you click a line number (and, optionally, type text), then submit without using "Save", the server-side version of the inline has no content.
- This gives you a no-effect warning. Instead, these inlines should probably just be marked as deleted somewhere in the pipeline.
- This saves the last "Saved" copy of the inline. That's (probably?) desired, but somewhat destructive without a warning.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21188

epriestley 468aabd4 b2ce0844

+3
+2
src/applications/audit/editor/PhabricatorAuditEditor.php
··· 105 105 106 106 switch ($xaction->getTransactionType()) { 107 107 case PhabricatorAuditActionConstants::INLINE: 108 + $xaction->getComment()->setAttribute('editing', false); 109 + return; 108 110 case PhabricatorAuditTransaction::TYPE_COMMIT: 109 111 return; 110 112 }
+1
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 112 112 113 113 switch ($xaction->getTransactionType()) { 114 114 case DifferentialTransaction::TYPE_INLINE: 115 + $xaction->getComment()->setAttribute('editing', false); 115 116 return; 116 117 } 117 118