recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Releeph: use relative URIs

Summary: I used the `PhabricatorEnv::getProductionURI()` in too many places to build Releeph URIs. The only places that should need full URIs are the links generated for Releeph emails, and in Conduit responses that link to Releeph objects.

Test Plan:
- Grep for `getProductionURI()` in Releeph, and make sure only sensible, non-DOM building places use it.
- Inspect the Releeph DOM to make sure hrefs etc. are relative.

Reviewers: wez, epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5999

Edward Speyer 46929207 824f9346

+3 -3
+1 -1
src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
··· 265 265 $body->addTextSection( 266 266 pht('RELEEPH BRANCH'), 267 267 $project_and_branch."\n". 268 - $releeph_branch->getURI()); 268 + PhabricatorEnv::getProductionURI($releeph_branch->getURI())); 269 269 270 270 return $body; 271 271 }
+1 -1
src/applications/releeph/storage/ReleephBranch.php
··· 98 98 rawurlencode($this->getBasename()), 99 99 $path 100 100 ); 101 - return PhabricatorEnv::getProductionURI(implode('/', $components)); 101 + return implode('/', $components); 102 102 } 103 103 104 104 public function loadReleephProject() {
+1 -1
src/applications/releeph/storage/ReleephProject.php
··· 51 51 $this->getID(), 52 52 $path 53 53 ); 54 - return PhabricatorEnv::getProductionURI(implode('/', $components)); 54 + return implode('/', $components); 55 55 } 56 56 57 57 public function setDetail($key, $value) {