@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence notifications - fix ordering
Summary: we get participation data ordered, then query conpherences by phid... be sure to resort the conpherences based on participation data. I missed this in testing 'cuz my test data is so trashy, but it is glaringly obvious in production. :/
Test Plan: replied to a very old conpherence and noted it was first in the notification panel
Reviewers: chad, epriestley
Reviewed By: epriestley
CC: Korvin, aran
Maniphest Tasks: T3641
Differential Revision: https://secure.phabricator.com/D6711
+3
+3
src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
+3
src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
···
28
28
29
29
if ($conpherences) {
30
30
require_celerity_resource('conpherence-notification-css');
31
+
// re-order the conpherences based on participation data
32
+
$conpherences = array_select_keys(
33
+
$conpherences, array_keys($participant_data));
31
34
$view = new AphrontNullView();
32
35
foreach ($conpherences as $conpherence) {
33
36
$p_data = $participant_data[$conpherence->getPHID()];