@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a bug for updating diffs
Summary: Hit this issue in D8485. I think reviewedByPHID changes should appear in application transactions.
Test Plan: Would like to deploy this and try updating D8485 again.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: aran, epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D8491
+1
-5
+1
-5
src/applications/differential/conduit/ConduitAPI_differential_Method.php
+1
-5
src/applications/differential/conduit/ConduitAPI_differential_Method.php
···
80
80
81
81
$role = PhabricatorCustomField::ROLE_APPLICATIONTRANSACTIONS;
82
82
if (!$field->shouldEnableForRole($role)) {
83
-
throw new Exception(
84
-
pht(
85
-
'Request attempts to update field "%s", but that field can not '.
86
-
'perform transactional updates.',
87
-
$key));
83
+
continue;
88
84
}
89
85
90
86
// TODO: This is fairly similar to PhabricatorCustomField's