@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove some ad-hoc loading of repositories from Releeph
Summary: Ref T3551. Since we now require repositories in order to perform policy checks, things that did loads properly don't need to load this data explicitly.
Test Plan: Edited a product, cut a new branch.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T3551
Differential Revision: https://secure.phabricator.com/D8769
+2
-6
+1
-2
src/applications/releeph/controller/branch/ReleephBranchCreateController.php
+1
-2
src/applications/releeph/controller/branch/ReleephBranchCreateController.php
···
31
31
$symbolic_name = $request->getStr('symbolicName');
32
32
33
33
if (!$cut_point) {
34
-
$repository = $product->loadPhabricatorRepository();
34
+
$repository = $product->getRepository();
35
35
switch ($repository->getVersionControlSystem()) {
36
36
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
37
37
break;
38
-
39
38
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
40
39
$cut_point = $product->getTrunkBranch();
41
40
break;
+1
-3
src/applications/releeph/controller/project/ReleephProductEditController.php
+1
-3
src/applications/releeph/controller/project/ReleephProductEditController.php
···
139
139
id(new AphrontFormStaticControl())
140
140
->setLabel(pht('Repository'))
141
141
->setValue(
142
-
$product
143
-
->loadPhabricatorRepository()
144
-
->getName()))
142
+
$product->getRepository()->getName()))
145
143
->appendChild(
146
144
id(new AphrontFormStaticControl())
147
145
->setLabel(pht('Arc Project'))