@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use sprites for all the menu icons

Summary:
See D3277, D3278.

- Sprite all the menu icons.
- Delete the unsprited versions.
- Notification bolt now uses the same style as everything else.

Test Plan: Looked at page, hovered, clicked things.

Reviewers: btrahan, chad, vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1569

Differential Revision: https://secure.phabricator.com/D3279

+25 -199
+1 -1
scripts/celerity/generate_sprites.php
··· 61 61 */ 62 62 63 63 .autosprite { 64 - background-image: url(/rsrc/image/autosprite.png); 64 + background-image: url(/rsrc/images/autosprite.png); 65 65 background-repeat: no-repeat; 66 66 } 67 67 EOCSS
+17 -148
src/__celerity_resource_map__.php
··· 133 133 'disk' => '/rsrc/image/appstatus_okay.png', 134 134 'type' => 'png', 135 135 ), 136 + '/rsrc/image/autosprite.png' => 137 + array( 138 + 'hash' => 'd02cc399dc950cd70006ef2374a6da4a', 139 + 'uri' => '/res/d02cc399/rsrc/image/autosprite.png', 140 + 'disk' => '/rsrc/image/autosprite.png', 141 + 'type' => 'png', 142 + ), 136 143 '/rsrc/image/avatar.png' => 137 144 array( 138 145 'hash' => '1c5f255071537f05406adee86717ff27', ··· 518 525 'disk' => '/rsrc/image/logo_grey.png', 519 526 'type' => 'png', 520 527 ), 521 - '/rsrc/image/menu/icon_help.png' => 522 - array( 523 - 'hash' => '874d2355508e8eafa052a1051c640880', 524 - 'uri' => '/res/874d2355/rsrc/image/menu/icon_help.png', 525 - 'disk' => '/rsrc/image/menu/icon_help.png', 526 - 'type' => 'png', 527 - ), 528 - '/rsrc/image/menu/icon_help_hover.png' => 529 - array( 530 - 'hash' => 'cf247b654052ebce0af28f03fd22c3ee', 531 - 'uri' => '/res/cf247b65/rsrc/image/menu/icon_help_hover.png', 532 - 'disk' => '/rsrc/image/menu/icon_help_hover.png', 533 - 'type' => 'png', 534 - ), 535 - '/rsrc/image/menu/icon_help_selected.png' => 536 - array( 537 - 'hash' => '59d79d47d28b87ca9a411a6c9617b038', 538 - 'uri' => '/res/59d79d47/rsrc/image/menu/icon_help_selected.png', 539 - 'disk' => '/rsrc/image/menu/icon_help_selected.png', 540 - 'type' => 'png', 541 - ), 542 - '/rsrc/image/menu/icon_logout.png' => 543 - array( 544 - 'hash' => '084d2bda82d5b996698a538b5ccdb46a', 545 - 'uri' => '/res/084d2bda/rsrc/image/menu/icon_logout.png', 546 - 'disk' => '/rsrc/image/menu/icon_logout.png', 547 - 'type' => 'png', 548 - ), 549 - '/rsrc/image/menu/icon_logout2x.png' => 550 - array( 551 - 'hash' => '5d11a6d23ad61f55b5793432df5acb0a', 552 - 'uri' => '/res/5d11a6d2/rsrc/image/menu/icon_logout2x.png', 553 - 'disk' => '/rsrc/image/menu/icon_logout2x.png', 554 - 'type' => 'png', 555 - ), 556 - '/rsrc/image/menu/icon_logout2x_hover.png' => 557 - array( 558 - 'hash' => '80e306c4d8f501da839ce4c80996d9fc', 559 - 'uri' => '/res/80e306c4/rsrc/image/menu/icon_logout2x_hover.png', 560 - 'disk' => '/rsrc/image/menu/icon_logout2x_hover.png', 561 - 'type' => 'png', 562 - ), 563 - '/rsrc/image/menu/icon_logout2x_selected.png' => 564 - array( 565 - 'hash' => 'aa2e3c875fcad31348df5c9fdccf7159', 566 - 'uri' => '/res/aa2e3c87/rsrc/image/menu/icon_logout2x_selected.png', 567 - 'disk' => '/rsrc/image/menu/icon_logout2x_selected.png', 568 - 'type' => 'png', 569 - ), 570 - '/rsrc/image/menu/icon_logout_hover.png' => 571 - array( 572 - 'hash' => 'e10818e44bb80106f9d2865de9dc5502', 573 - 'uri' => '/res/e10818e4/rsrc/image/menu/icon_logout_hover.png', 574 - 'disk' => '/rsrc/image/menu/icon_logout_hover.png', 575 - 'type' => 'png', 576 - ), 577 - '/rsrc/image/menu/icon_logout_selected.png' => 578 - array( 579 - 'hash' => '71129452753f4b079b03c67eb11dabc2', 580 - 'uri' => '/res/71129452/rsrc/image/menu/icon_logout_selected.png', 581 - 'disk' => '/rsrc/image/menu/icon_logout_selected.png', 582 - 'type' => 'png', 583 - ), 584 - '/rsrc/image/menu/icon_settings.png' => 585 - array( 586 - 'hash' => '247b9e58e0ee2b0e3c2d85eec0fb56de', 587 - 'uri' => '/res/247b9e58/rsrc/image/menu/icon_settings.png', 588 - 'disk' => '/rsrc/image/menu/icon_settings.png', 589 - 'type' => 'png', 590 - ), 591 - '/rsrc/image/menu/icon_settings2x.png' => 592 - array( 593 - 'hash' => 'f2c6723a9fed69c760a8dbbb4a28878c', 594 - 'uri' => '/res/f2c6723a/rsrc/image/menu/icon_settings2x.png', 595 - 'disk' => '/rsrc/image/menu/icon_settings2x.png', 596 - 'type' => 'png', 597 - ), 598 - '/rsrc/image/menu/icon_settings2x_hover.png' => 599 - array( 600 - 'hash' => 'dcd473539fe94fb79335c895a7dbe873', 601 - 'uri' => '/res/dcd47353/rsrc/image/menu/icon_settings2x_hover.png', 602 - 'disk' => '/rsrc/image/menu/icon_settings2x_hover.png', 603 - 'type' => 'png', 604 - ), 605 - '/rsrc/image/menu/icon_settings2x_selected.png' => 606 - array( 607 - 'hash' => '5fac19e4b0c18426c264a5915ba36ce7', 608 - 'uri' => '/res/5fac19e4/rsrc/image/menu/icon_settings2x_selected.png', 609 - 'disk' => '/rsrc/image/menu/icon_settings2x_selected.png', 610 - 'type' => 'png', 611 - ), 612 - '/rsrc/image/menu/icon_settings_hover.png' => 613 - array( 614 - 'hash' => '1ba90f62880d57ef04b6c3bc3450f9e1', 615 - 'uri' => '/res/1ba90f62/rsrc/image/menu/icon_settings_hover.png', 616 - 'disk' => '/rsrc/image/menu/icon_settings_hover.png', 617 - 'type' => 'png', 618 - ), 619 - '/rsrc/image/menu/icon_settings_selected.png' => 620 - array( 621 - 'hash' => '52274d9a722786b1110afef9e6055c79', 622 - 'uri' => '/res/52274d9a/rsrc/image/menu/icon_settings_selected.png', 623 - 'disk' => '/rsrc/image/menu/icon_settings_selected.png', 624 - 'type' => 'png', 625 - ), 626 - '/rsrc/image/menu/icon_task.png' => 627 - array( 628 - 'hash' => 'cb6706766e6587c98fe68431e2d6653c', 629 - 'uri' => '/res/cb670676/rsrc/image/menu/icon_task.png', 630 - 'disk' => '/rsrc/image/menu/icon_task.png', 631 - 'type' => 'png', 632 - ), 633 - '/rsrc/image/menu/icon_task2x.png' => 634 - array( 635 - 'hash' => '884c90a8d97eebf34457a1d0f68d53b5', 636 - 'uri' => '/res/884c90a8/rsrc/image/menu/icon_task2x.png', 637 - 'disk' => '/rsrc/image/menu/icon_task2x.png', 638 - 'type' => 'png', 639 - ), 640 - '/rsrc/image/menu/icon_task2x_hover.png' => 641 - array( 642 - 'hash' => 'a9875f3572c50cafe048b95608b5c63e', 643 - 'uri' => '/res/a9875f35/rsrc/image/menu/icon_task2x_hover.png', 644 - 'disk' => '/rsrc/image/menu/icon_task2x_hover.png', 645 - 'type' => 'png', 646 - ), 647 - '/rsrc/image/menu/icon_task2x_selected.png' => 648 - array( 649 - 'hash' => 'ea8a192e3396468079564bcdeeeae434', 650 - 'uri' => '/res/ea8a192e/rsrc/image/menu/icon_task2x_selected.png', 651 - 'disk' => '/rsrc/image/menu/icon_task2x_selected.png', 652 - 'type' => 'png', 653 - ), 654 - '/rsrc/image/menu/icon_task_hover.png' => 655 - array( 656 - 'hash' => '97af34be5cfd65a58040ad123e12b596', 657 - 'uri' => '/res/97af34be/rsrc/image/menu/icon_task_hover.png', 658 - 'disk' => '/rsrc/image/menu/icon_task_hover.png', 659 - 'type' => 'png', 660 - ), 661 - '/rsrc/image/menu/icon_task_selected.png' => 662 - array( 663 - 'hash' => '9d3dfdb15fd43ec784271758c5bc10bc', 664 - 'uri' => '/res/9d3dfdb1/rsrc/image/menu/icon_task_selected.png', 665 - 'disk' => '/rsrc/image/menu/icon_task_selected.png', 666 - 'type' => 'png', 667 - ), 668 528 '/rsrc/image/search.png' => 669 529 array( 670 530 'hash' => 'ff7da044e6f923b8f569dec11f97e5e5', ··· 857 717 array( 858 718 ), 859 719 'disk' => '/rsrc/css/aphront/typeahead.css', 720 + ), 721 + 'autosprite-css' => 722 + array( 723 + 'uri' => '/res/ef26301d/rsrc/css/autosprite.css', 724 + 'type' => 'css', 725 + 'requires' => 726 + array( 727 + ), 728 + 'disk' => '/rsrc/css/autosprite.css', 860 729 ), 861 730 'differential-changeset-view-css' => 862 731 array( ··· 2579 2448 ), 2580 2449 'phabricator-main-menu-view' => 2581 2450 array( 2582 - 'uri' => '/res/a768260e/rsrc/css/application/base/main-menu-view.css', 2451 + 'uri' => '/res/a51c5f64/rsrc/css/application/base/main-menu-view.css', 2583 2452 'type' => 'css', 2584 2453 'requires' => 2585 2454 array(
+1 -1
src/applications/auth/application/PhabricatorApplicationAuth.php
··· 37 37 if ($user->isLoggedIn()) { 38 38 $item = new PhabricatorMainMenuIconView(); 39 39 $item->setName(pht('Log Out')); 40 - $item->addClass('main-menu-item-icon '.$class); 40 + $item->addClass('autosprite main-menu-item-icon '.$class); 41 41 $item->setWorkflow(true); 42 42 $item->setHref('/logout/'); 43 43 $item->setSortOrder(1.0);
+1 -1
src/applications/diviner/application/PhabricatorApplicationDiviner.php
··· 37 37 $class = 'main-menu-item-icon-help'; 38 38 $item = new PhabricatorMainMenuIconView(); 39 39 $item->setName(pht('%s Help', $application->getName())); 40 - $item->addClass('main-menu-item-icon '.$class); 40 + $item->addClass('autosprite main-menu-item-icon '.$class); 41 41 $item->setHref($application->getHelpURI()); 42 42 $item->setSortOrder(0.1); 43 43 $items[] = $item;
+2 -2
src/applications/settings/application/PhabricatorApplicationSettings.php
··· 45 45 46 46 $items = array(); 47 47 48 - if ($controller instanceof PhabricatorUserSettingsController) { 48 + if ($controller instanceof PhabricatorSettingsMainController) { 49 49 $class = 'main-menu-item-icon-settings-selected'; 50 50 } else { 51 51 $class = 'main-menu-item-icon-settings'; ··· 54 54 if ($user->isLoggedIn()) { 55 55 $item = new PhabricatorMainMenuIconView(); 56 56 $item->setName(pht('Settings')); 57 - $item->addClass('main-menu-item-icon '.$class); 57 + $item->addClass('autosprite main-menu-item-icon '.$class); 58 58 $item->setHref('/settings/'); 59 59 $item->setSortOrder(0.90); 60 60 $items[] = $item;
+1
src/view/page/PhabricatorStandardPageView.php
··· 138 138 $console = $this->getConsole(); 139 139 140 140 require_celerity_resource('phabricator-core-css'); 141 + require_celerity_resource('autosprite-css'); 141 142 require_celerity_resource('phabricator-core-buttons-css'); 142 143 require_celerity_resource('phabricator-standard-page-view'); 143 144
+2
src/view/page/menu/PhabricatorMainMenuView.php
··· 108 108 $classes = array(); 109 109 $classes[] = 'phabricator-main-menu-alert-item'; 110 110 $classes[] = 'phabricator-main-menu-alert-item-notification'; 111 + $classes[] = 'autosprite'; 112 + $classes[] = 'main-menu-item-icon-notifications'; 111 113 112 114 $notification_icon = javelin_render_tag( 113 115 'a',
-46
webroot/rsrc/css/application/base/main-menu-view.css
··· 148 148 height: 26px; 149 149 margin: 9px 6px; 150 150 display: inline-block; 151 - background-repeat: no-repeat; 152 151 } 153 152 154 153 .device-desktop .phabricator-main-menu-icon-label { ··· 171 170 .device-phone .phabricator-main-menu-icon { 172 171 margin-left: 20px; 173 172 position: absolute; 174 - } 175 - 176 - .main-menu-item-icon { 177 - background-repeat: no-repeat; 178 - background-size: 26px 26px; 179 - } 180 - 181 - .main-menu-item-icon-settings { 182 - background-image: url(/rsrc/image/menu/icon_settings.png); 183 - } 184 - 185 - .main-menu-item-icon-settings:hover { 186 - background-image: url(/rsrc/image/menu/icon_settings_hover.png); 187 - } 188 - 189 - .main-menu-item-icon-settings-selected { 190 - background-image: url(/rsrc/image/menu/icon_settings_selected.png); 191 - } 192 - 193 - .main-menu-item-icon-logout { 194 - background-image: url(/rsrc/image/menu/icon_logout.png); 195 - } 196 - 197 - .main-menu-item-icon-logout:hover { 198 - background-image: url(/rsrc/image/menu/icon_logout_hover.png); 199 - } 200 - 201 - .main-menu-item-icon-logout-selected { 202 - background-image: url(/rsrc/image/menu/icon_logout_selected.png); 203 - } 204 - 205 - .main-menu-item-icon-help { 206 - background-image: url(/rsrc/image/menu/icon_help.png); 207 - } 208 - 209 - .main-menu-item-icon-help:hover { 210 - background-image: url(/rsrc/image/menu/icon_help_hover.png); 211 - } 212 - 213 - .main-menu-item-icon-help-selected { 214 - background-image: url(/rsrc/image/menu/icon_help_selected.png); 215 173 } 216 174 217 175 .main-menu-item-icon-profile { ··· 426 384 font-weight: bold; 427 385 color: #ffffff; 428 386 } 429 - 430 - .phabricator-main-menu-alert-item-notification { 431 - background: url(/rsrc/image/bolt.png) no-repeat; 432 - }
webroot/rsrc/image/bolt.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_help.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_help_hover.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_help_selected.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_logout.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_logout2x.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_logout2x_hover.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_logout2x_selected.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_logout_hover.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_logout_selected.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_settings.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_settings2x.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_settings2x_hover.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_settings2x_selected.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_settings_hover.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_settings_selected.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_task.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_task2x.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_task2x_hover.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_task2x_selected.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_task_hover.png

This is a binary file and will not be displayed.

webroot/rsrc/image/menu/icon_task_selected.png

This is a binary file and will not be displayed.