@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Convert phutil_render_tag(X, Y, phutil_escape_html(Z)) to phutil_tag

Summary:
Created with spatch:

lang=diff
- phutil_render_tag
+ phutil_tag
(X, Y,
- phutil_escape_html(
Z
- )
)

Test Plan: Loaded homepage

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4501

vrana 48561a8b f8dbfdd5

+225 -231
+4 -4
src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
··· 333 333 '$'.$part['line']; 334 334 $attrs['target'] = '_blank'; 335 335 } 336 - $file_name = phutil_render_tag( 336 + $file_name = phutil_tag( 337 337 'a', 338 338 $attrs, 339 - phutil_escape_html($relative)); 339 + $relative); 340 340 } else { 341 - $file_name = phutil_render_tag( 341 + $file_name = phutil_tag( 342 342 'span', 343 343 array( 344 344 'title' => $file, 345 345 ), 346 - phutil_escape_html($relative)); 346 + $relative); 347 347 } 348 348 $file_name = $file_name.' : '.(int)$part['line']; 349 349 } else {
+4 -4
src/aphront/console/plugin/DarkConsoleErrorLogPlugin.php
··· 39 39 $file = $row['file']; 40 40 $line = $row['line']; 41 41 42 - $tag = phutil_render_tag( 42 + $tag = phutil_tag( 43 43 'a', 44 44 array( 45 45 'onclick' => jsprintf('show_details(%d)', $index), 46 46 ), 47 - phutil_escape_html($row['str'].' at ['.basename($file).':'.$line.']')); 47 + $row['str'].' at ['.basename($file).':'.$line.']'); 48 48 $rows[] = array($tag); 49 49 50 50 $details .= ··· 70 70 } 71 71 } 72 72 73 - $details .= phutil_render_tag( 73 + $details .= phutil_tag( 74 74 'a', 75 75 array( 76 76 'href' => $href, 77 77 ), 78 - phutil_escape_html($line)); 78 + $line); 79 79 $details .= "\n"; 80 80 } 81 81
+2 -2
src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
··· 16 16 foreach ($channels as $channel) { 17 17 $name = $channel['channel']; 18 18 $rows[] = array( 19 - phutil_render_tag( 19 + phutil_tag( 20 20 'a', 21 21 array( 22 22 'href' => '/chatlog/channel/'.phutil_escape_uri($name).'/', 23 23 ), 24 - phutil_escape_html($name))); 24 + $name)); 25 25 } 26 26 27 27 $table = new AphrontTableView($rows);
+2 -2
src/applications/conduit/controller/PhabricatorConduitListController.php
··· 25 25 26 26 $rows[] = array( 27 27 $group, 28 - phutil_render_tag( 28 + phutil_tag( 29 29 'a', 30 30 array( 31 31 'href' => '/conduit/method/'.$info['full_name'], 32 32 ), 33 - phutil_escape_html($info['full_name'])), 33 + $info['full_name']), 34 34 $info['description'], 35 35 $status, 36 36 );
+2 -2
src/applications/config/controller/PhabricatorConfigAllController.php
··· 24 24 } 25 25 26 26 $rows[] = array( 27 - phutil_render_tag( 27 + phutil_tag( 28 28 'a', 29 29 array( 30 30 'href' => $this->getApplicationURI('edit/'.$key.'/'), 31 31 ), 32 - phutil_escape_html($key)), 32 + $key), 33 33 $value, 34 34 ); 35 35 }
+6 -6
src/applications/config/view/PhabricatorSetupIssueView.php
··· 95 95 ), 96 96 pht('To continue, resolve this problem and reload the page.')); 97 97 98 - $name = phutil_render_tag( 98 + $name = phutil_tag( 99 99 'div', 100 100 array( 101 101 'class' => 'setup-issue-name', 102 102 ), 103 - phutil_escape_html($issue->getName())); 103 + $issue->getName()); 104 104 105 105 return phutil_render_tag( 106 106 'div', ··· 283 283 "To update these %d value(s), edit your PHP configuration file, ". 284 284 "located here:", 285 285 count($configs))); 286 - $info .= phutil_render_tag( 286 + $info .= phutil_tag( 287 287 'pre', 288 288 array(), 289 - phutil_escape_html($ini_loc)); 289 + $ini_loc); 290 290 } 291 291 292 292 if ($more_loc) { ··· 296 296 pht( 297 297 "PHP also loaded these configuration file(s):", 298 298 count($more_loc))); 299 - $info .= phutil_render_tag( 299 + $info .= phutil_tag( 300 300 'pre', 301 301 array(), 302 - phutil_escape_html(implode("\n", $more_loc))); 302 + implode("\n", $more_loc)); 303 303 } 304 304 305 305 $info .= phutil_render_tag(
+2 -2
src/applications/countdown/controller/PhabricatorCountdownListController.php
··· 48 48 $rows[] = array( 49 49 phutil_escape_html($timer->getID()), 50 50 $handles[$timer->getAuthorPHID()]->renderLink(), 51 - phutil_render_tag( 51 + phutil_tag( 52 52 'a', 53 53 array( 54 54 'href' => '/countdown/'.$timer->getID().'/', 55 55 ), 56 - phutil_escape_html($timer->getTitle())), 56 + $timer->getTitle()), 57 57 phabricator_datetime($timer->getDatepoint(), $user), 58 58 $edit_button, 59 59 $delete_button,
+2 -2
src/applications/daemon/view/PhabricatorDaemonLogEventsView.php
··· 69 69 if ($this->combinedLog) { 70 70 array_unshift( 71 71 $row, 72 - phutil_render_tag( 72 + phutil_tag( 73 73 'a', 74 74 array( 75 75 'href' => '/daemon/log/'.$event->getLogID().'/', 76 76 ), 77 - phutil_escape_html('Daemon '.$event->getLogID()))); 77 + 'Daemon '.$event->getLogID())); 78 78 } 79 79 80 80 $rows[] = $row;
+4 -4
src/applications/differential/controller/DifferentialDiffViewController.php
··· 19 19 if ($diff->getRevisionID()) { 20 20 $top_panel = new AphrontPanelView(); 21 21 $top_panel->setWidth(AphrontPanelView::WIDTH_WIDE); 22 - $link = phutil_render_tag( 22 + $link = phutil_tag( 23 23 'a', 24 24 array( 25 25 'href' => PhabricatorEnv::getURI('/D'.$diff->getRevisionID()), 26 26 ), 27 - phutil_escape_html('D'.$diff->getRevisionID())); 27 + 'D'.$diff->getRevisionID()); 28 28 $top_panel->appendChild( 29 29 "<h1>".pht('This diff belongs to revision %s', $link)."</h1>"); 30 30 } else { ··· 52 52 if ($revisions) { 53 53 $select[] = '<optgroup label="'.pht('Update Existing Revision').'">'; 54 54 foreach ($revisions as $revision) { 55 - $select[] = phutil_render_tag( 55 + $select[] = phutil_tag( 56 56 'option', 57 57 array( 58 58 'value' => $revision->getID(), 59 59 ), 60 - phutil_escape_html($revision->getTitle())); 60 + $revision->getTitle()); 61 61 } 62 62 $select[] = '</optgroup>'; 63 63 }
+2 -2
src/applications/differential/field/specification/DifferentialTitleFieldSpecification.php
··· 87 87 } 88 88 89 89 public function renderValueForRevisionList(DifferentialRevision $revision) { 90 - return phutil_render_tag( 90 + return phutil_tag( 91 91 'a', 92 92 array( 93 93 'href' => '/D'.$revision->getID(), 94 94 ), 95 - phutil_escape_html($revision->getTitle())); 95 + $revision->getTitle()); 96 96 } 97 97 98 98 }
+2 -2
src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php
··· 97 97 ), 98 98 ''); 99 99 100 - $name_element = phutil_render_tag( 100 + $name_element = phutil_tag( 101 101 'span', 102 102 array( 103 103 'class' => 'phabricator-filetree-name', 104 104 ), 105 - phutil_escape_html($name)); 105 + $name); 106 106 107 107 $filetree[] = javelin_render_tag( 108 108 $href ? 'a' : 'span',
+4 -4
src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
··· 145 145 } 146 146 $last_base = $base; 147 147 148 - $id_link = phutil_render_tag( 148 + $id_link = phutil_tag( 149 149 'a', 150 150 array('href' => '/differential/diff/'.$id.'/'), 151 - phutil_escape_html($id)); 151 + $id); 152 152 $rows[] = 153 153 '<tr'.$class.'>'. 154 154 '<td class="revhistory-name">'.phutil_escape_html($name).'</td>'. ··· 179 179 180 180 $select = '<select name="whitespace">'; 181 181 foreach ($options as $value => $label) { 182 - $select .= phutil_render_tag( 182 + $select .= phutil_tag( 183 183 'option', 184 184 array( 185 185 'value' => $value, ··· 187 187 ? 'selected' 188 188 : null, 189 189 ), 190 - phutil_escape_html($label)); 190 + $label); 191 191 } 192 192 $select .= '</select>'; 193 193
+8 -8
src/applications/diffusion/controller/DiffusionBrowseFileController.php
··· 178 178 case 'plain': 179 179 $style = 180 180 "margin: 1em 2em; width: 90%; height: 80em; font-family: monospace"; 181 - $corpus = phutil_render_tag( 181 + $corpus = phutil_tag( 182 182 'textarea', 183 183 array( 184 184 'style' => $style, 185 185 ), 186 - phutil_escape_html($file_query->getRawData())); 186 + $file_query->getRawData()); 187 187 188 188 break; 189 189 ··· 205 205 sprintf("%-10s %-20s %s", substr($rev, 0, 7), $author, $line); 206 206 } 207 207 208 - $corpus = phutil_render_tag( 208 + $corpus = phutil_tag( 209 209 'textarea', 210 210 array( 211 211 'style' => $style, 212 212 ), 213 - phutil_escape_html(implode("\n", $rows))); 213 + implode("\n", $rows)); 214 214 215 215 break; 216 216 ··· 493 493 if (isset($blame['handle'])) { 494 494 $author_link = $blame['handle']->renderLink(); 495 495 } else { 496 - $author_link = phutil_render_tag( 496 + $author_link = phutil_tag( 497 497 'span', 498 498 array( 499 499 ), 500 - phutil_escape_html($blame['author'])); 500 + $blame['author']); 501 501 } 502 502 $display_line['author'] = $author_link; 503 503 ··· 699 699 idx($line, 'author')); 700 700 } 701 701 702 - $line_link = phutil_render_tag( 702 + $line_link = phutil_tag( 703 703 'a', 704 704 array( 705 705 'href' => $line_href, 706 706 ), 707 - phutil_escape_html($line['line'])); 707 + $line['line']); 708 708 709 709 $blame[] = javelin_render_tag( 710 710 'th',
+2 -2
src/applications/diffusion/controller/DiffusionCommitBranchesController.php
··· 14 14 15 15 $branch_links = array(); 16 16 foreach ($branches as $branch => $commit) { 17 - $branch_links[] = phutil_render_tag( 17 + $branch_links[] = phutil_tag( 18 18 'a', 19 19 array( 20 20 'href' => $request->generateURI( ··· 23 23 'branch' => $branch, 24 24 )), 25 25 ), 26 - phutil_escape_html($branch)); 26 + $branch); 27 27 } 28 28 29 29 return id(new AphrontAjaxResponse())
+6 -6
src/applications/diffusion/controller/DiffusionCommitController.php
··· 178 178 $change_panel->setID('toc'); 179 179 180 180 if ($count > self::CHANGES_LIMIT) { 181 - $show_all_button = phutil_render_tag( 181 + $show_all_button = phutil_tag( 182 182 'a', 183 183 array( 184 184 'class' => 'button green', 185 185 'href' => '?show_all=true', 186 186 ), 187 - phutil_escape_html('Show All Changes')); 187 + 'Show All Changes'); 188 188 $warning_view = id(new AphrontErrorView()) 189 189 ->setSeverity(AphrontErrorView::SEVERITY_WARNING) 190 190 ->setTitle('Very Large Commit') ··· 399 399 if ($commit->getAuditStatus()) { 400 400 $status = PhabricatorAuditCommitStatusConstants::getStatusName( 401 401 $commit->getAuditStatus()); 402 - $props['Status'] = phutil_render_tag( 402 + $props['Status'] = phutil_tag( 403 403 'strong', 404 404 array(), 405 - phutil_escape_html($status)); 405 + $status); 406 406 } 407 407 408 408 $props['Committed'] = phabricator_datetime($commit->getEpoch(), $user); ··· 892 892 893 893 $ref_links = array(); 894 894 foreach ($refs as $ref) { 895 - $ref_links[] = phutil_render_tag( 895 + $ref_links[] = phutil_tag( 896 896 'a', 897 897 array( 898 898 'href' => $request->generateURI( ··· 901 901 'branch' => $ref, 902 902 )), 903 903 ), 904 - phutil_escape_html($ref)); 904 + $ref); 905 905 } 906 906 $ref_links = implode(', ', $ref_links); 907 907 return $ref_links;
+2 -2
src/applications/diffusion/controller/DiffusionCommitTagsController.php
··· 19 19 20 20 $tag_links = array(); 21 21 foreach ($tags as $tag) { 22 - $tag_links[] = phutil_render_tag( 22 + $tag_links[] = phutil_tag( 23 23 'a', 24 24 array( 25 25 'href' => $request->generateURI( ··· 28 28 'commit' => $tag->getName(), 29 29 )), 30 30 ), 31 - phutil_escape_html($tag->getName())); 31 + $tag->getName()); 32 32 } 33 33 34 34 if ($has_more_tags) {
+2 -2
src/applications/diffusion/controller/DiffusionController.php
··· 278 278 $thus_far = ''; 279 279 foreach ($path_parts as $path_part) { 280 280 $thus_far .= $path_part.'/'; 281 - $path_sections[] = phutil_render_tag( 281 + $path_sections[] = phutil_tag( 282 282 'a', 283 283 array( 284 284 'href' => $drequest->generateURI( ··· 286 286 'path' => $thus_far, 287 287 ) + $uri_params), 288 288 ), 289 - phutil_escape_html($path_part)); 289 + $path_part); 290 290 } 291 291 292 292 $path_sections[] = phutil_escape_html($last);
+2 -3
src/applications/diffusion/controller/DiffusionExternalController.php
··· 95 95 'commit' => $commit->getCommitIdentifier(), 96 96 )); 97 97 $rows[] = array( 98 - phutil_render_tag( 98 + phutil_tag( 99 99 'a', 100 100 array( 101 101 'href' => $href, 102 102 ), 103 - phutil_escape_html( 104 - 'r'.$repo->getCallsign().$commit->getCommitIdentifier())), 103 + 'r'.$repo->getCallsign().$commit->getCommitIdentifier()), 105 104 phutil_escape_html($commit->loadCommitData()->getSummary()), 106 105 ); 107 106 }
+2 -2
src/applications/diffusion/controller/DiffusionHistoryController.php
··· 47 47 $copies_new = true; 48 48 } 49 49 50 - $button = phutil_render_tag( 50 + $button = phutil_tag( 51 51 'a', 52 52 array( 53 53 'class' => 'button small grey', 54 54 'href' => $request->getRequestURI()->alter('copies', $copies_new), 55 55 ), 56 - phutil_escape_html($button_title)); 56 + $button_title); 57 57 58 58 $history_table = new DiffusionHistoryTableView(); 59 59 $history_table->setUser($request->getUser());
+4 -4
src/applications/diffusion/controller/DiffusionHomeController.php
··· 13 13 $rows = array(); 14 14 foreach ($shortcuts as $shortcut) { 15 15 $rows[] = array( 16 - phutil_render_tag( 16 + phutil_tag( 17 17 'a', 18 18 array( 19 19 'href' => $shortcut->getHref(), 20 20 ), 21 - phutil_escape_html($shortcut->getName())), 21 + $shortcut->getName()), 22 22 phutil_escape_html($shortcut->getDescription()), 23 23 ); 24 24 } ··· 124 124 } 125 125 126 126 $rows[] = array( 127 - phutil_render_tag( 127 + phutil_tag( 128 128 'a', 129 129 array( 130 130 'href' => '/diffusion/'.$repository->getCallsign().'/', 131 131 ), 132 - phutil_escape_html($repository->getName())), 132 + $repository->getName()), 133 133 phutil_escape_html($repository->getDetail('description')), 134 134 PhabricatorRepositoryType::getNameForRepositoryType( 135 135 $repository->getVersionControlSystem()),
+2 -2
src/applications/diffusion/controller/DiffusionSymbolController.php
··· 94 94 return id(new AphrontRedirectResponse())->setURI($href); 95 95 } 96 96 97 - $location = phutil_render_tag( 97 + $location = phutil_tag( 98 98 'a', 99 99 array( 100 100 'href' => $href, 101 101 ), 102 - phutil_escape_html($file.':'.$line)); 102 + $file.':'.$line); 103 103 } else if ($file) { 104 104 $location = phutil_escape_html($file.':'.$line); 105 105 } else {
+2 -2
src/applications/diffusion/view/DiffusionBranchTableView.php
··· 47 47 ), 48 48 'History' 49 49 ), 50 - phutil_render_tag( 50 + phutil_tag( 51 51 'a', 52 52 array( 53 53 'href' => $drequest->generateURI( ··· 56 56 'branch' => $branch->getName(), 57 57 )), 58 58 ), 59 - phutil_escape_html($branch->getName())), 59 + $branch->getName()), 60 60 self::linkCommit( 61 61 $drequest->getRepository(), 62 62 $branch->getHeadCommitIdentifier()),
+2 -2
src/applications/diffusion/view/DiffusionBrowseTableView.php
··· 278 278 279 279 require_celerity_resource('diffusion-icons-css'); 280 280 281 - return phutil_render_tag( 281 + return phutil_tag( 282 282 'span', 283 283 array( 284 284 'class' => 'diffusion-path-icon diffusion-path-icon-'.$type, 285 285 ), 286 - phutil_escape_html($text)); 286 + $text); 287 287 } 288 288 289 289 }
+4 -5
src/applications/diffusion/view/DiffusionTagListView.php
··· 34 34 foreach ($this->tags as $tag) { 35 35 $commit = idx($this->commits, $tag->getCommitIdentifier()); 36 36 37 - $tag_link = phutil_render_tag( 37 + $tag_link = phutil_tag( 38 38 'a', 39 39 array( 40 40 'href' => $drequest->generateURI( ··· 43 43 'commit' => $tag->getName(), 44 44 )), 45 45 ), 46 - phutil_escape_html($tag->getName())); 46 + $tag->getName()); 47 47 48 - $commit_link = phutil_render_tag( 48 + $commit_link = phutil_tag( 49 49 'a', 50 50 array( 51 51 'href' => $drequest->generateURI( ··· 54 54 'commit' => $tag->getCommitIdentifier(), 55 55 )), 56 56 ), 57 - phutil_escape_html( 58 57 $repository->formatCommitName( 59 - $tag->getCommitIdentifier()))); 58 + $tag->getCommitIdentifier())); 60 59 61 60 $author = null; 62 61 if ($commit && $commit->getAuthorPHID()) {
+2 -2
src/applications/diviner/controller/DivinerListController.php
··· 33 33 $name = $link['name']; 34 34 $flavor = $link['flavor']; 35 35 36 - $link = phutil_render_tag( 36 + $link = phutil_tag( 37 37 'a', 38 38 array( 39 39 'href' => $href, 40 40 'target' => '_blank', 41 41 ), 42 - phutil_escape_html($name)); 42 + $name); 43 43 44 44 $out[] = 45 45 '<div class="aphront-directory-item">'.
+6 -6
src/applications/drydock/controller/DrydockController.php
··· 32 32 $lease_uri = $this->getApplicationURI($lease_uri); 33 33 34 34 $rows[] = array( 35 - phutil_render_tag( 35 + phutil_tag( 36 36 'a', 37 37 array( 38 38 'href' => $resource_uri, 39 39 ), 40 - phutil_escape_html($log->getResourceID())), 41 - phutil_render_tag( 40 + $log->getResourceID()), 41 + phutil_tag( 42 42 'a', 43 43 array( 44 44 'href' => $lease_uri, 45 45 ), 46 - phutil_escape_html($log->getLeaseID())), 46 + $log->getLeaseID()), 47 47 phutil_escape_html($log->getMessage()), 48 48 phabricator_date($log->getEpoch(), $user), 49 49 ); ··· 96 96 $resource_name = $resource->getName(); 97 97 98 98 $item->addAttribute( 99 - phutil_render_tag( 99 + phutil_tag( 100 100 'a', 101 101 array( 102 102 'href' => $resource_href, 103 103 ), 104 - phutil_escape_html($resource_name))); 104 + $resource_name)); 105 105 } 106 106 107 107 $status = DrydockLeaseStatus::getNameForStatus($lease->getStatus());
+2 -2
src/applications/feed/builder/PhabricatorFeedBuilder.php
··· 45 45 } 46 46 $last_date = $date; 47 47 $null_view->appendChild( 48 - phutil_render_tag( 48 + phutil_tag( 49 49 'div', 50 50 array( 51 51 'class' => 'phabricator-feed-story-date', 52 52 ), 53 - phutil_escape_html($date))); 53 + $date)); 54 54 } 55 55 56 56 $view = $story->renderView();
+2 -2
src/applications/feed/story/PhabricatorFeedStory.php
··· 233 233 // NOTE: We render our own link here to customize the styling and add 234 234 // the '_top' target for framed feeds. 235 235 236 - return phutil_render_tag( 236 + return phutil_tag( 237 237 'a', 238 238 array( 239 239 'href' => $handle->getURI(), 240 240 'target' => $this->framed ? '_top' : null, 241 241 ), 242 - phutil_escape_html($handle->getLinkName())); 242 + $handle->getLinkName()); 243 243 } 244 244 245 245 final protected function renderString($str) {
+2 -2
src/applications/herald/controller/HeraldTranscriptController.php
··· 481 481 } 482 482 483 483 if (strlen($value) > 256) { 484 - $value = phutil_render_tag( 484 + $value = phutil_tag( 485 485 'textarea', 486 486 array( 487 487 'class' => 'herald-field-value-transcript', 488 488 ), 489 - phutil_escape_html($value)); 489 + $value); 490 490 } else if ($name === 'Object Link') { 491 491 // The link cannot be escaped 492 492 } else {
+2 -2
src/applications/herald/view/HeraldRuleEditHistoryView.php
··· 25 25 26 26 foreach ($this->edits as $edit) { 27 27 $name = nonempty($edit->getRuleName(), 'Unknown Rule'); 28 - $rule_name = phutil_render_tag( 28 + $rule_name = phutil_tag( 29 29 'strong', 30 30 array(), 31 - phutil_escape_html($name)); 31 + $name); 32 32 33 33 switch ($edit->getAction()) { 34 34 case 'create':
+2 -2
src/applications/herald/view/HeraldRuleListView.php
··· 44 44 $author = $this->handles[$rule->getAuthorPHID()]->renderLink(); 45 45 } 46 46 47 - $name = phutil_render_tag( 47 + $name = phutil_tag( 48 48 'a', 49 49 array( 50 50 'href' => '/herald/rule/'.$rule->getID().'/', 51 51 ), 52 - phutil_escape_html($rule->getName())); 52 + $rule->getName()); 53 53 54 54 $edit_log = phutil_render_tag( 55 55 'a',
+4 -4
src/applications/maniphest/controller/ManiphestReportController.php
··· 478 478 } 479 479 480 480 $tasks = idx($result, $handle->getPHID(), array()); 481 - $name = phutil_render_tag( 481 + $name = phutil_tag( 482 482 'a', 483 483 array( 484 484 'href' => $base_link.$handle->getPHID(), 485 485 ), 486 - phutil_escape_html($handle->getName())); 486 + $handle->getName()); 487 487 $closed = idx($result_closed, $handle->getPHID(), array()); 488 488 } else { 489 489 $tasks = $leftover; ··· 524 524 525 525 if ($closed) { 526 526 $task_ids = implode(',', mpull($closed, 'getID')); 527 - $row[] = phutil_render_tag( 527 + $row[] = phutil_tag( 528 528 'a', 529 529 array( 530 530 'href' => '/maniphest/view/custom/?s=oc&tasks='.$task_ids, 531 531 'target' => '_blank', 532 532 ), 533 - phutil_escape_html(number_format(count($closed)))); 533 + number_format(count($closed))); 534 534 } else { 535 535 $row[] = '-'; 536 536 }
+2 -2
src/applications/maniphest/controller/ManiphestSavedQueryListController.php
··· 48 48 'value' => $query->getID(), 49 49 'checked' => ($query->getIsDefault() ? 'checked' : null), 50 50 )), 51 - phutil_render_tag( 51 + phutil_tag( 52 52 'a', 53 53 array( 54 54 'href' => '/maniphest/view/custom/?key='.$query->getQueryKey(), 55 55 ), 56 - phutil_escape_html($query->getName())), 56 + $query->getName()), 57 57 phutil_render_tag( 58 58 'a', 59 59 array(
+2 -2
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 457 457 $subject = '[T'.$task->getID().'] '.$task->getTitle(); 458 458 $view->addProperty( 459 459 pht('From Email'), 460 - phutil_render_tag( 460 + phutil_tag( 461 461 'a', 462 462 array( 463 463 'href' => 'mailto:'.$source.'?subject='.$subject 464 464 ), 465 - phutil_escape_html($source))); 465 + $source)); 466 466 } 467 467 468 468 $view->addProperty(
+2 -3
src/applications/maniphest/view/ManiphestTaskProjectsView.php
··· 21 21 22 22 $tags = array(); 23 23 foreach ($show as $handle) { 24 - $tags[] = phutil_render_tag( 24 + $tags[] = phutil_tag( 25 25 'a', 26 26 array( 27 27 'href' => $handle->getURI(), 28 28 'class' => 'phabricator-project-tag', 29 29 ), 30 - phutil_escape_html( 31 - phutil_utf8_shorten($handle->getName(), 24))); 30 + phutil_utf8_shorten($handle->getName(), 24)); 32 31 } 33 32 34 33 if (count($this->handles) > 2) {
+2 -2
src/applications/maniphest/view/ManiphestTaskSummaryView.php
··· 119 119 : '<em>None</em>'). 120 120 '</td>'. 121 121 '<td class="maniphest-task-name">'. 122 - phutil_render_tag( 122 + phutil_tag( 123 123 'a', 124 124 array( 125 125 'href' => '/T'.$task->getID(), 126 126 ), 127 - phutil_escape_html($task->getTitle())). 127 + $task->getTitle()). 128 128 '</td>'. 129 129 '<td class="maniphest-task-projects">'. 130 130 $projects_view->render().
+6 -6
src/applications/meta/view/PhabricatorApplicationLaunchView.php
··· 31 31 $icon = null; 32 32 $create_button = null; 33 33 if ($application) { 34 - $content[] = phutil_render_tag( 34 + $content[] = phutil_tag( 35 35 'span', 36 36 array( 37 37 'class' => 'phabricator-application-launch-name', 38 38 ), 39 - phutil_escape_html($application->getName())); 39 + $application->getName()); 40 40 41 41 if ($application->isBeta()) { 42 42 $content[] = phutil_render_tag( ··· 48 48 } 49 49 50 50 if ($this->fullWidth) { 51 - $content[] = phutil_render_tag( 51 + $content[] = phutil_tag( 52 52 'span', 53 53 array( 54 54 'class' => 'phabricator-application-launch-description', 55 55 ), 56 - phutil_escape_html($application->getShortDescription())); 56 + $application->getShortDescription()); 57 57 } 58 58 59 59 $count = 0; ··· 64 64 } 65 65 66 66 if ($count) { 67 - $content[] = phutil_render_tag( 67 + $content[] = phutil_tag( 68 68 'span', 69 69 array( 70 70 'class' => 'phabricator-application-launch-attention', 71 71 ), 72 - phutil_escape_html($count)); 72 + $count); 73 73 } 74 74 75 75 $classes = array();
+2 -2
src/applications/meta/view/PhabricatorApplicationStatusView.php
··· 37 37 'phabricator-application-status-type-'.$this->type, 38 38 ); 39 39 40 - return phutil_render_tag( 40 + return phutil_tag( 41 41 'span', 42 42 array( 43 43 'class' => implode(' ', $classes), 44 44 ), 45 - phutil_escape_html($this->text)); 45 + $this->text); 46 46 } 47 47 48 48 }
+2 -2
src/applications/metamta/PhabricatorMetaMTAWorker.php
··· 42 42 } 43 43 44 44 public function renderForDisplay() { 45 - return phutil_render_tag( 45 + return phutil_tag( 46 46 'a', 47 47 array('href' => '/mail/view/'.$this->getTaskData().'/'), 48 - phutil_escape_html($this->getTaskData())); 48 + $this->getTaskData()); 49 49 } 50 50 51 51 }
+4 -4
src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
··· 31 31 $highlight = $this->getHighlightPHIDs(); 32 32 foreach ($clients as $client) { 33 33 $row = array( 34 - phutil_render_tag( 34 + phutil_tag( 35 35 'a', 36 36 array( 37 37 'href' => $client->getViewURI(), 38 38 ), 39 - phutil_escape_html($client->getName()) 39 + $client->getName() 40 40 ), 41 41 $client->getPHID(), 42 42 $client->getSecret(), 43 - phutil_render_tag( 43 + phutil_tag( 44 44 'a', 45 45 array( 46 46 'href' => $client->getRedirectURI(), 47 47 ), 48 - phutil_escape_html($client->getRedirectURI()) 48 + $client->getRedirectURI() 49 49 ), 50 50 phutil_render_tag( 51 51 'a',
+2 -2
src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationEditController.php
··· 61 61 id(new AphrontFormMarkupControl()) 62 62 ->setLabel('Client') 63 63 ->setValue( 64 - phutil_render_tag( 64 + phutil_tag( 65 65 'a', 66 66 array( 67 67 'href' => $client->getViewURI(), 68 68 ), 69 - phutil_escape_html($client->getName()))) 69 + $client->getName())) 70 70 ) 71 71 ->appendChild( 72 72 id(new AphrontFormStaticControl())
+2 -2
src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationListController.php
··· 50 50 'article/Using_the_Phabricator_OAuth_Server.html#scopes' 51 51 ); 52 52 $row = array( 53 - phutil_render_tag( 53 + phutil_tag( 54 54 'a', 55 55 array( 56 56 'href' => $client->getViewURI(), 57 57 ), 58 - phutil_escape_html($client->getName()) 58 + $client->getName() 59 59 ), 60 60 phutil_render_tag( 61 61 'a',
+2 -2
src/applications/owners/controller/PhabricatorOwnersDetailController.php
··· 94 94 )); 95 95 $repo_name = '<strong>'.phutil_escape_html($repo->getName()). 96 96 '</strong>'; 97 - $path_link = phutil_render_tag( 97 + $path_link = phutil_tag( 98 98 'a', 99 99 array( 100 100 'href' => (string) $href, 101 101 ), 102 - phutil_escape_html($path->getPath())); 102 + $path->getPath()); 103 103 $path_links[] = 104 104 ($path->getExcluded() ? '&ndash;' : '+').' '. 105 105 $repo_name.' '.$path_link;
+6 -6
src/applications/owners/controller/PhabricatorOwnersListController.php
··· 254 254 $pkg_paths[$key] = 255 255 ($path->getExcluded() ? '&ndash;' : '+').' '. 256 256 '<strong>'.phutil_escape_html($repo->getName()).'</strong> '. 257 - phutil_render_tag( 257 + phutil_tag( 258 258 'a', 259 259 array( 260 260 'href' => (string) $href, 261 261 ), 262 - phutil_escape_html($path->getPath())); 262 + $path->getPath()); 263 263 } else { 264 264 $pkg_paths[$key] = phutil_escape_html($path->getPath()); 265 265 } ··· 267 267 $pkg_paths = implode('<br />', $pkg_paths); 268 268 269 269 $rows[] = array( 270 - phutil_render_tag( 270 + phutil_tag( 271 271 'a', 272 272 array( 273 273 'href' => '/owners/package/'.$package->getID().'/', 274 274 ), 275 - phutil_escape_html($package->getName())), 275 + $package->getName()), 276 276 $pkg_owners, 277 277 $pkg_paths, 278 - phutil_render_tag( 278 + phutil_tag( 279 279 'a', 280 280 array( 281 281 'href' => '/audit/view/packagecommits/?phid='.$package->getPHID(), 282 282 ), 283 - phutil_escape_html('Related Commits')) 283 + 'Related Commits') 284 284 ); 285 285 } 286 286
+2 -2
src/applications/people/controller/PhabricatorPeopleListController.php
··· 49 49 $rows[] = array( 50 50 phabricator_date($user->getDateCreated(), $viewer), 51 51 phabricator_time($user->getDateCreated(), $viewer), 52 - phutil_render_tag( 52 + phutil_tag( 53 53 'a', 54 54 array( 55 55 'href' => '/p/'.$user->getUsername().'/', 56 56 ), 57 - phutil_escape_html($user->getUserName())), 57 + $user->getUserName()), 58 58 phutil_escape_html($user->getRealName()), 59 59 $status, 60 60 $email,
+4 -4
src/applications/people/controller/PhabricatorPeopleLogsController.php
··· 163 163 phutil_escape_html($handles[$log->getUserPHID()]->getName()), 164 164 json_encode($log->getOldValue(), true), 165 165 json_encode($log->getNewValue(), true), 166 - phutil_render_tag( 166 + phutil_tag( 167 167 'a', 168 168 array( 169 169 'href' => $request 170 170 ->getRequestURI() 171 171 ->alter('ip', $log->getRemoteAddr()), 172 172 ), 173 - phutil_escape_html($log->getRemoteAddr())), 174 - phutil_render_tag( 173 + $log->getRemoteAddr()), 174 + phutil_tag( 175 175 'a', 176 176 array( 177 177 'href' => $request 178 178 ->getRequestURI() 179 179 ->alter('session', $log->getSession()), 180 180 ), 181 - phutil_escape_html($log->getSession())), 181 + $log->getSession()), 182 182 ); 183 183 } 184 184
+4 -5
src/applications/phame/view/PhamePostView.php
··· 64 64 array( 65 65 'class' => 'phame-post-title', 66 66 ), 67 - phutil_render_tag( 67 + phutil_tag( 68 68 'a', 69 69 array( 70 70 'href' => $href, 71 71 ), 72 - phutil_escape_html($this->getPost()->getTitle()))); 72 + $this->getPost()->getTitle())); 73 73 } 74 74 75 75 public function renderDatePublished() { 76 - return phutil_render_tag( 76 + return phutil_tag( 77 77 'div', 78 78 array( 79 79 'class' => 'phame-post-date', 80 80 ), 81 - phutil_escape_html( 82 81 pht( 83 82 'Published on %s by %s', 84 83 phabricator_datetime( 85 84 $this->getPost()->getDatePublished(), 86 85 $this->getUser()), 87 - $this->getAuthor()->getName()))); 86 + $this->getAuthor()->getName())); 88 87 } 89 88 90 89 public function renderBody() {
+2 -2
src/applications/phid/PhabricatorObjectHandle.php
··· 190 190 $title = 'disabled'; // Overwrite status. 191 191 } 192 192 193 - return phutil_render_tag( 193 + return phutil_tag( 194 194 'a', 195 195 array( 196 196 'href' => $this->getURI(), 197 197 'class' => $class, 198 198 'title' => $title, 199 199 ), 200 - phutil_escape_html($name)); 200 + $name); 201 201 } 202 202 203 203 public function getLinkName() {
+2 -2
src/applications/phid/controller/PhabricatorPHIDLookupController.php
··· 13 13 $rows = array(); 14 14 foreach ($handles as $handle) { 15 15 if ($handle->getURI()) { 16 - $link = phutil_render_tag( 16 + $link = phutil_tag( 17 17 'a', 18 18 array( 19 19 'href' => $handle->getURI(), 20 20 ), 21 - phutil_escape_html($handle->getURI())); 21 + $handle->getURI()); 22 22 } else { 23 23 $link = null; 24 24 }
+2 -2
src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
··· 18 18 $name = $token->getTypeName(); 19 19 $title = "Token {$seq}: {$name}"; 20 20 21 - $tokens[] = phutil_render_tag( 21 + $tokens[] = phutil_tag( 22 22 'span', 23 23 array( 24 24 'title' => $title, 25 25 'class' => 'token', 26 26 ), 27 - phutil_escape_html($token->getValue())); 27 + $token->getValue()); 28 28 } 29 29 30 30 return $this->buildXHPASTViewPanelResponse(implode('', $tokens));
+2 -2
src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php
··· 29 29 $tree = array(); 30 30 $tree[] = 31 31 '<li>'. 32 - phutil_render_tag( 32 + phutil_tag( 33 33 'span', 34 34 array( 35 35 'title' => $title, 36 36 ), 37 - phutil_escape_html($name)). 37 + $name). 38 38 '</li>'; 39 39 foreach ($root->getChildren() as $child) { 40 40 $tree[] = '<ul>'.$this->buildTree($child).'</ul>';
+2 -2
src/applications/phriction/controller/PhrictionDiffController.php
··· 104 104 $crumbs->setCrumbs( 105 105 array( 106 106 'Phriction', 107 - phutil_render_tag( 107 + phutil_tag( 108 108 'a', 109 109 array( 110 110 'href' => PhrictionDocument::getSlugURI($slug), 111 111 ), 112 - phutil_escape_html($current->getTitle())), 112 + $current->getTitle()), 113 113 phutil_render_tag( 114 114 'a', 115 115 array(
+2 -2
src/applications/phriction/controller/PhrictionDocumentController.php
··· 341 341 342 342 private function renderChildDocumentLink(array $info) { 343 343 $title = nonempty($info['title'], '(Untitled Document)'); 344 - $item = phutil_render_tag( 344 + $item = phutil_tag( 345 345 'a', 346 346 array( 347 347 'href' => PhrictionDocument::getSlugURI($info['slug']), 348 348 ), 349 - phutil_escape_html($title)); 349 + $title); 350 350 351 351 if (isset($info['empty'])) { 352 352 $item = '<em>'.$item.'</em>';
+2 -2
src/applications/phriction/controller/PhrictionListController.php
··· 53 53 $content = $document->getContent(); 54 54 $rows[] = array( 55 55 $handles[$content->getAuthorPHID()]->renderLink(), 56 - phutil_render_tag( 56 + phutil_tag( 57 57 'a', 58 58 array( 59 59 'href' => PhrictionDocument::getSlugURI($document->getSlug()), 60 60 ), 61 - phutil_escape_html($content->getTitle())), 61 + $content->getTitle()), 62 62 phabricator_date($content->getDateCreated(), $user), 63 63 phabricator_time($content->getDateCreated(), $user), 64 64 );
+2 -2
src/applications/policy/filter/PhabricatorPolicy.php
··· 77 77 78 78 public function renderDescription() { 79 79 if ($this->getHref()) { 80 - $desc = phutil_render_tag( 80 + $desc = phutil_tag( 81 81 'a', 82 82 array( 83 83 'href' => $this->getHref(), 84 84 ), 85 - phutil_escape_html($this->getName())); 85 + $this->getName()); 86 86 } else { 87 87 $desc = phutil_escape_html($this->getName()); 88 88 }
+1 -3
src/applications/ponder/view/PonderQuestionSummaryView.php
··· 48 48 49 49 $title = 50 50 '<h2 class="ponder-question-title">'. 51 - phutil_render_tag( 51 + phutil_tag( 52 52 'a', 53 53 array( 54 54 "href" => '/Q' . $question->getID(), 55 55 ), 56 - phutil_escape_html( 57 56 'Q' . $question->getID() . 58 57 ' ' . $question->getTitle() 59 - ) 60 58 ) . 61 59 '</h2>'; 62 60
+4 -4
src/applications/project/controller/PhabricatorProjectListController.php
··· 100 100 101 101 102 102 $rows[] = array( 103 - phutil_render_tag( 103 + phutil_tag( 104 104 'a', 105 105 array( 106 106 'href' => '/project/view/'.$project->getID().'/', 107 107 ), 108 - phutil_escape_html($project->getName())), 108 + $project->getName()), 109 109 phutil_escape_html( 110 110 PhabricatorProjectStatus::getNameForStatus($project->getStatus())), 111 111 phutil_escape_html($blurb), 112 112 phutil_escape_html($population), 113 - phutil_render_tag( 113 + phutil_tag( 114 114 'a', 115 115 array( 116 116 'href' => '/maniphest/view/all/?projects='.$phid, 117 117 ), 118 - phutil_escape_html($task_count)), 118 + $task_count), 119 119 ); 120 120 } 121 121
+2 -2
src/applications/settings/panel/PhabricatorSettingsPanelProfile.php
··· 160 160 id(new AphrontFormMarkupControl()) 161 161 ->setLabel('Profile URI') 162 162 ->setValue( 163 - phutil_render_tag( 163 + phutil_tag( 164 164 'a', 165 165 array( 166 166 'href' => $profile_uri, 167 167 ), 168 - phutil_escape_html($profile_uri)))) 168 + $profile_uri))) 169 169 ->appendChild( 170 170 '<p class="aphront-form-instructions">Write something about yourself! '. 171 171 'Make sure to include <strong>important information</strong> like '.
+2 -2
src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php
··· 176 176 $rows = array(); 177 177 foreach ($keys as $key) { 178 178 $rows[] = array( 179 - phutil_render_tag( 179 + phutil_tag( 180 180 'a', 181 181 array( 182 182 'href' => $this->getPanelURI('?edit='.$key->getID()), 183 183 ), 184 - phutil_escape_html($key->getName())), 184 + $key->getName()), 185 185 phutil_escape_html($key->getKeyComment()), 186 186 phutil_escape_html($key->getKeyType()), 187 187 phabricator_date($key->getDateCreated(), $user),
+2 -2
src/applications/slowvote/controller/PhabricatorSlowvoteListController.php
··· 46 46 foreach ($polls as $poll) { 47 47 $rows[] = array( 48 48 'V'.$poll->getID(), 49 - phutil_render_tag( 49 + phutil_tag( 50 50 'a', 51 51 array( 52 52 'href' => '/V'.$poll->getID(), 53 53 ), 54 - phutil_escape_html($poll->getQuestion())), 54 + $poll->getQuestion()), 55 55 $handles[$poll->getAuthorPHID()]->renderLink(), 56 56 phabricator_date($poll->getDateCreated(), $user), 57 57 phabricator_time($poll->getDateCreated(), $user),
+2 -2
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
··· 115 115 $preview = id(new PhabricatorTimelineView()) 116 116 ->setID($this->getPreviewTimelineID()); 117 117 118 - $header = phutil_render_tag( 118 + $header = phutil_tag( 119 119 'div', 120 120 array( 121 121 'class' => 'phabricator-timeline-preview-header', 122 122 ), 123 - phutil_escape_html(pht('Preview'))); 123 + pht('Preview')); 124 124 125 125 return phutil_render_tag( 126 126 'div',
+2 -2
src/applications/uiexample/examples/PhabricatorBarePageExample.php
··· 13 13 public function renderExample() { 14 14 $view = new PhabricatorBarePageView(); 15 15 $view->appendChild( 16 - phutil_render_tag( 16 + phutil_tag( 17 17 'h1', 18 18 array(), 19 - phutil_escape_html($this->getDescription()))); 19 + $this->getDescription())); 20 20 21 21 $response = new AphrontWebpageResponse(); 22 22 $response->setContent($view->render());
+2 -2
src/applications/uiexample/examples/PhabricatorButtonsExample.php
··· 28 28 $class .= ' button'; 29 29 } 30 30 31 - $view[] = phutil_render_tag( 31 + $view[] = phutil_tag( 32 32 $tag, 33 33 array( 34 34 'class' => $class, 35 35 ), 36 - phutil_escape_html(ucwords($size.' '.$color.' '.$tag))); 36 + ucwords($size.' '.$color.' '.$tag)); 37 37 38 38 $view[] = '<br /><br />'; 39 39 }
+2 -2
src/applications/xhprof/view/PhabricatorXHProfProfileView.php
··· 16 16 } 17 17 18 18 protected function renderSymbolLink($symbol) { 19 - return phutil_render_tag( 19 + return phutil_tag( 20 20 'a', 21 21 array( 22 22 'href' => $this->baseURI.'?symbol='.$symbol, 23 23 'target' => $this->isFramed ? '_top' : null, 24 24 ), 25 - phutil_escape_html($symbol)); 25 + $symbol); 26 26 } 27 27 28 28 }
+4 -4
src/infrastructure/markup/rule/PhabricatorRemarkupRuleMention.php
··· 95 95 } 96 96 97 97 if ($exists) { 98 - $tag = phutil_render_tag( 98 + $tag = phutil_tag( 99 99 'a', 100 100 array( 101 101 'class' => $class, ··· 103 103 'target' => '_blank', 104 104 'title' => $actual_users[$username]['realName'], 105 105 ), 106 - phutil_escape_html('@'.$actual_users[$username]['username'])); 106 + '@'.$actual_users[$username]['username']); 107 107 foreach ($tokens as $token) { 108 108 $engine->overwriteStoredText($token, $tag); 109 109 } ··· 112 112 // because we want to preserve the original text capitalization and it 113 113 // may differ for each token. 114 114 foreach ($tokens as $token) { 115 - $tag = phutil_render_tag( 115 + $tag = phutil_tag( 116 116 'span', 117 117 array( 118 118 'class' => $class, 119 119 ), 120 - phutil_escape_html('@'.idx($original, $token, $username))); 120 + '@'.idx($original, $token, $username)); 121 121 $engine->overwriteStoredText($token, $tag); 122 122 } 123 123 }
+2 -2
src/infrastructure/markup/rule/PhabricatorRemarkupRulePhriction.php
··· 30 30 if ($this->getEngine()->getState('toc')) { 31 31 $text = phutil_escape_html($name); 32 32 } else { 33 - $text = phutil_render_tag( 33 + $text = phutil_tag( 34 34 'a', 35 35 array( 36 36 'href' => $href, 37 37 'class' => 'phriction-link', 38 38 ), 39 - phutil_escape_html($name)); 39 + $name); 40 40 } 41 41 42 42 return $this->getEngine()->storeText($text);
+2 -2
src/view/control/AphrontAttachedFileView.php
··· 23 23 'height' => 45, 24 24 )); 25 25 26 - $name = phutil_render_tag( 26 + $name = phutil_tag( 27 27 'a', 28 28 array( 29 29 'href' => $file->getViewURI(), 30 30 'target' => '_blank', 31 31 ), 32 - phutil_escape_html($file->getName())); 32 + $file->getName()); 33 33 $size = number_format($file->getByteSize()).' bytes'; 34 34 35 35 $remove = javelin_render_tag(
+2 -2
src/view/control/AphrontTableView.php
··· 210 210 'class' => 'aphront-table-view-nodevice', 211 211 ), 212 212 $header); 213 - $header_device = phutil_render_tag( 213 + $header_device = phutil_tag( 214 214 'span', 215 215 array( 216 216 'class' => 'aphront-table-view-device', 217 217 ), 218 - phutil_escape_html($short_headers[$col_num])); 218 + $short_headers[$col_num]); 219 219 220 220 $header = $header_nodevice.$header_device; 221 221 }
+4 -4
src/view/form/AphrontErrorView.php
··· 40 40 if ($errors) { 41 41 $list = array(); 42 42 foreach ($errors as $error) { 43 - $list[] = phutil_render_tag( 43 + $list[] = phutil_tag( 44 44 'li', 45 45 array(), 46 - phutil_escape_html($error)); 46 + $error); 47 47 } 48 48 $list = phutil_render_tag( 49 49 'ul', ··· 57 57 58 58 $title = $this->title; 59 59 if (strlen($title)) { 60 - $title = phutil_render_tag( 60 + $title = phutil_tag( 61 61 'h1', 62 62 array( 63 63 'class' => 'aphront-error-view-head', 64 64 ), 65 - phutil_escape_html($title)); 65 + $title); 66 66 } else { 67 67 $title = null; 68 68 }
+2 -2
src/view/form/control/AphrontFormCheckboxControl.php
··· 32 32 'checked' => $box['checked'] ? 'checked' : null, 33 33 'disabled' => $this->getDisabled() ? 'disabled' : null, 34 34 )); 35 - $label = phutil_render_tag( 35 + $label = phutil_tag( 36 36 'label', 37 37 array( 38 38 'for' => $id, 39 39 ), 40 - phutil_escape_html($box['label'])); 40 + $box['label']); 41 41 $rows[] = 42 42 '<tr>'. 43 43 '<td>'.$checkbox.'</td>'.
+2 -2
src/view/form/control/AphrontFormRadioButtonControl.php
··· 34 34 : null, 35 35 'disabled' => $this->getDisabled() ? 'disabled' : null, 36 36 )); 37 - $label = phutil_render_tag( 37 + $label = phutil_tag( 38 38 'label', 39 39 array( 40 40 'for' => $id, 41 41 'class' => $button['class'], 42 42 ), 43 - phutil_escape_html($button['label'])); 43 + $button['label']); 44 44 45 45 if (strlen($button['caption'])) { 46 46 $label .=
+2 -2
src/view/form/control/AphrontFormSelectControl.php
··· 52 52 ), 53 53 implode("\n", self::renderOptions($selected, $thing))); 54 54 } else { 55 - $tags[] = phutil_render_tag( 55 + $tags[] = phutil_tag( 56 56 'option', 57 57 array( 58 58 'selected' => ($value == $selected) ? 'selected' : null, 59 59 'value' => $value, 60 60 ), 61 - phutil_escape_html($thing)); 61 + $thing); 62 62 } 63 63 } 64 64 return $tags;
+4 -4
src/view/form/control/AphrontFormSubmitControl.php
··· 5 5 protected $cancelButton; 6 6 7 7 public function addCancelButton($href, $label = 'Cancel') { 8 - $this->cancelButton = phutil_render_tag( 8 + $this->cancelButton = phutil_tag( 9 9 'a', 10 10 array( 11 11 'href' => $href, 12 12 'class' => 'button grey', 13 13 ), 14 - phutil_escape_html($label)); 14 + $label); 15 15 return $this; 16 16 } 17 17 ··· 22 22 protected function renderInput() { 23 23 $submit_button = null; 24 24 if ($this->getValue()) { 25 - $submit_button = phutil_render_tag( 25 + $submit_button = phutil_tag( 26 26 'button', 27 27 array( 28 28 'name' => '__submit__', 29 29 'disabled' => $this->getDisabled() ? 'disabled' : null, 30 30 ), 31 - phutil_escape_html($this->getValue())); 31 + $this->getValue()); 32 32 } 33 33 return $submit_button.$this->cancelButton; 34 34 }
+2 -2
src/view/form/control/AphrontFormTextAreaControl.php
··· 61 61 $classes[] = $this->customClass; 62 62 $classes = trim(implode(' ', $classes)); 63 63 64 - return phutil_render_tag( 64 + return phutil_tag( 65 65 'textarea', 66 66 array( 67 67 'name' => $this->getName(), ··· 72 72 'id' => $this->getID(), 73 73 'placeholder' => $this->getPlaceHolder(), 74 74 ), 75 - phutil_escape_html($this->getValue())); 75 + $this->getValue()); 76 76 } 77 77 78 78 }
+2 -2
src/view/form/control/AphrontFormToggleButtonsControl.php
··· 37 37 $more = null; 38 38 } 39 39 40 - $out[] = phutil_render_tag( 40 + $out[] = phutil_tag( 41 41 'a', 42 42 array( 43 43 'class' => 'toggle'.$more, 44 44 'href' => $this->baseURI->alter($this->param, $value), 45 45 ), 46 - phutil_escape_html($label)); 46 + $label); 47 47 } 48 48 49 49 return implode('', $out);
+2 -2
src/view/layout/PhabricatorActionView.php
··· 92 92 phutil_escape_html($this->name)); 93 93 } 94 94 } else { 95 - $item = phutil_render_tag( 95 + $item = phutil_tag( 96 96 'span', 97 97 array( 98 98 'class' => 'phabricator-action-view-item', 99 99 ), 100 - phutil_escape_html($this->name)); 100 + $this->name); 101 101 } 102 102 103 103 $classes = array();
+2 -2
src/view/layout/PhabricatorHeaderView.php
··· 27 27 $header = phutil_escape_html($this->header); 28 28 29 29 if ($this->objectName) { 30 - $header = phutil_render_tag( 30 + $header = phutil_tag( 31 31 'a', 32 32 array( 33 33 'href' => '/'.$this->objectName, 34 34 ), 35 - phutil_escape_html($this->objectName)).' '.$header; 35 + $this->objectName).' '.$header; 36 36 } 37 37 38 38 if ($this->tags) {
+2 -2
src/view/layout/PhabricatorMenuItemView.php
··· 117 117 if ($this->isExternal) { 118 118 $external = " \xE2\x86\x97"; 119 119 } 120 - $name = phutil_render_tag( 120 + $name = phutil_tag( 121 121 'span', 122 122 array( 123 123 'class' => 'phabricator-menu-item-name', 124 124 ), 125 - phutil_escape_html($this->name.$external)); 125 + $this->name.$external); 126 126 } 127 127 128 128 return $this->renderChildren().$name;
+2 -2
src/view/layout/PhabricatorObjectItemListView.php
··· 32 32 33 33 $header = null; 34 34 if (strlen($this->header)) { 35 - $header = phutil_render_tag( 35 + $header = phutil_tag( 36 36 'h1', 37 37 array( 38 38 'class' => 'phabricator-object-item-list-header', 39 39 ), 40 - phutil_escape_html($this->header)); 40 + $this->header); 41 41 } 42 42 43 43 if ($this->items) {
+4 -4
src/view/layout/PhabricatorObjectItemView.php
··· 71 71 } 72 72 73 73 public function render() { 74 - $header = phutil_render_tag( 74 + $header = phutil_tag( 75 75 'a', 76 76 array( 77 77 'href' => $this->href, 78 78 'class' => 'phabricator-object-item-name', 79 79 ), 80 - phutil_escape_html($this->header)); 80 + $this->header); 81 81 82 82 $icons = null; 83 83 if ($this->icons) { ··· 93 93 ), 94 94 ''); 95 95 96 - $label = phutil_render_tag( 96 + $label = phutil_tag( 97 97 'span', 98 98 array( 99 99 'class' => 'phabricator-object-item-icon-label', 100 100 ), 101 - phutil_escape_html($spec['label'])); 101 + $spec['label']); 102 102 103 103 $icon_list[] = phutil_render_tag( 104 104 'li',
+4 -4
src/view/layout/PhabricatorPropertyListView.php
··· 87 87 $key = $spec['key']; 88 88 $value = $spec['value']; 89 89 90 - $items[] = phutil_render_tag( 90 + $items[] = phutil_tag( 91 91 'dt', 92 92 array( 93 93 'class' => 'phabricator-property-list-key', 94 94 ), 95 - phutil_escape_html($key)); 95 + $key); 96 96 $items[] = phutil_render_tag( 97 97 'dd', 98 98 array( ··· 137 137 } 138 138 139 139 private function renderSectionPart(array $part) { 140 - return phutil_render_tag( 140 + return phutil_tag( 141 141 'div', 142 142 array( 143 143 'class' => 'phabricator-property-list-section-header', 144 144 ), 145 - phutil_escape_html($part['name'])); 145 + $part['name']); 146 146 } 147 147 148 148 private function renderTextPart(array $part) {
+2 -2
src/view/layout/PhabricatorTransactionView.php
··· 105 105 ->setAnchorName($this->anchorName) 106 106 ->render(); 107 107 108 - $info[] = $anchor.phutil_render_tag( 108 + $info[] = $anchor.phutil_tag( 109 109 'a', 110 110 array( 111 111 'href' => '#'.$this->anchorName, 112 112 ), 113 - phutil_escape_html($this->anchorText)); 113 + $this->anchorText); 114 114 } 115 115 116 116 $info = implode(' &middot; ', $info);
+2 -2
src/view/layout/headsup/AphrontHeadsupView.php
··· 30 30 public function render() { 31 31 $header = 32 32 '<h1>'. 33 - phutil_render_tag( 33 + phutil_tag( 34 34 'a', 35 35 array( 36 36 'href' => '/'.$this->objectName, 37 37 'class' => 'aphront-headsup-object-name', 38 38 ), 39 - phutil_escape_html($this->objectName)). 39 + $this->objectName). 40 40 ' '. 41 41 phutil_escape_html($this->header). 42 42 '</h1>';
+2 -2
src/view/page/menu/PhabricatorMainMenuView.php
··· 303 303 $count_number = "\xE2\x88\x9E"; 304 304 } 305 305 306 - $count_tag = phutil_render_tag( 306 + $count_tag = phutil_tag( 307 307 'span', 308 308 array( 309 309 'id' => $count_id, 310 310 'class' => 'phabricator-main-menu-alert-count' 311 311 ), 312 - phutil_escape_html($count_number)); 312 + $count_number); 313 313 314 314 $icon_tag = phutil_render_tag( 315 315 'span',