@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix reentrancy guard in setDebugTimeLimit()
Summary: $initialized is never initialized and onDebugTick() may be registered multiple times.
Test Plan: None. The function is normally only called once.
Reviewers: O1 Blessed Committers, speck
Reviewed By: O1 Blessed Committers, speck
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25469
+2
-1
+2
-1
support/startup/PhabricatorStartup.php
+2
-1
support/startup/PhabricatorStartup.php
···
261
261
public static function setDebugTimeLimit($limit) {
262
262
self::$debugTimeLimit = $limit;
263
263
264
-
static $initialized;
264
+
static $initialized = false;
265
265
if (!$initialized) {
266
266
declare(ticks=1);
267
267
register_tick_function(array(__CLASS__, 'onDebugTick'));
268
+
$initialized = true;
268
269
}
269
270
}
270
271