@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove `-t -t` from Drydock SSH interface
Summary: These arguments prevent stderr from being routed correctly for Linux hosts and break Windows entirely. Removing them fixes the issue.
Test Plan: Removed those options and both Linux and Windows hosts had their output fed back into Harbormaster correctly.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Maniphest Tasks: T4111, T1029
Differential Revision: https://secure.phabricator.com/D7710
+1
-3
+1
-3
src/applications/drydock/interface/command/DrydockSSHCommandInterface.php
+1
-3
src/applications/drydock/interface/command/DrydockSSHCommandInterface.php
···
44
44
$full_command = 'C:\\Windows\\system32\\cmd.exe /C '.$full_command;
45
45
}
46
46
47
-
// NOTE: The "-t -t" is for psuedo-tty allocation so we can "sudo" on some
48
-
// systems, but maybe more trouble than it's worth?
49
47
return new ExecFuture(
50
-
'ssh -t -t -o StrictHostKeyChecking=no -p %s -i %P %P@%s -- %s',
48
+
'ssh -o StrictHostKeyChecking=no -p %s -i %P %P@%s -- %s',
51
49
$this->getConfig('port'),
52
50
$this->passphraseSSHKey->getKeyfileEnvelope(),
53
51
$this->passphraseSSHKey->getUsernameEnvelope(),