recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Adding some type names to object handles

Summary:
I browsed through the applications and searched for all flaggable objects and gave them names. Only flaggable ones, since they were the only ones I deemed important for my future diff(s). Also, I thought that this method may be deprecated in some way, since it only included some older applications

Also adding proper fallback. Without makes my future diff(s) non-fatal in a user-confusing way (imagine you are displaying the object type ## ## (`null` ^^))

Also usable for Refs T1048

Test Plan: Used in a future diff, names appear, fallback works as expected.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1048

Differential Revision: https://secure.phabricator.com/D5514

authored by

Anh Nhan Nguyen and committed by
epriestley 48f1a578 d9cd4589

+10 -2
+10 -2
src/applications/phid/PhabricatorObjectHandle.php
··· 111 111 PhabricatorPHIDConstants::PHID_TYPE_TASK => 'Task', 112 112 PhabricatorPHIDConstants::PHID_TYPE_DREV => 'Revision', 113 113 PhabricatorPHIDConstants::PHID_TYPE_CMIT => 'Commit', 114 - PhabricatorPHIDConstants::PHID_TYPE_WIKI => 'Phriction', 114 + PhabricatorPHIDConstants::PHID_TYPE_WIKI => 'Phriction Document', 115 + PhabricatorPHIDConstants::PHID_TYPE_MCRO => 'Image Macro', 116 + PhabricatorPHIDConstants::PHID_TYPE_MOCK => 'Pholio Mock', 117 + PhabricatorPHIDConstants::PHID_TYPE_FILE => 'File', 118 + PhabricatorPHIDConstants::PHID_TYPE_BLOG => 'Blog', 119 + PhabricatorPHIDConstants::PHID_TYPE_POST => 'Post', 120 + PhabricatorPHIDConstants::PHID_TYPE_QUES => 'Question', 121 + PhabricatorPHIDConstants::PHID_TYPE_PVAR => 'Variable', 122 + PhabricatorPHIDConstants::PHID_TYPE_PSTE => 'Paste', 115 123 ); 116 124 117 - return idx($map, $this->getType()); 125 + return idx($map, $this->getType(), $this->getType()); 118 126 } 119 127 120 128