recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Drop nonsense buildStatus field from Buildable

Summary:
Ref T4809. Buildables currently have buildStatus and buildableStatus. Neither are used, and no one knows why we have two.

I'm going to use buildableStatus shortly, but buildStatus is meaningless; burn it.

Test Plan: `grep`, examined similar get/set calls, created a new buildable, ran storage upgrade.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4809

Differential Revision: https://secure.phabricator.com/D8796

epriestley 4918773a 7c1bcdea

+2 -2
+2
resources/sql/autopatches/20140416.harbor.1.sql
··· 1 + ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildable 2 + DROP buildStatus;
-2
src/applications/harbormaster/storage/HarbormasterBuildable.php
··· 7 7 8 8 protected $buildablePHID; 9 9 protected $containerPHID; 10 - protected $buildStatus; 11 10 protected $buildableStatus; 12 11 protected $isManualBuildable; 13 12 ··· 22 21 public static function initializeNewBuildable(PhabricatorUser $actor) { 23 22 return id(new HarbormasterBuildable()) 24 23 ->setIsManualBuildable(0) 25 - ->setBuildStatus(self::STATUS_WHATEVER) 26 24 ->setBuildableStatus(self::STATUS_WHATEVER); 27 25 } 28 26