recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove documentation about obsolete Differential event listeners

Summary:
Fixes T5069. T2222 mostly-intentionally stopped emitting these.

My sense is that users generally find event listeners (or, really, writing PHP at all) much less preferable to things like Herald rules or HTTP hooks. This is generally good, since those things are way easier to maintain, so I plan to continue moving away from events in cases where we have reasonable alternatives.

We also generally have more and better alternatives now than when these were written.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5069

Differential Revision: https://secure.phabricator.com/D9151

epriestley 4925dd7e 45f4431a

-41
-38
src/docs/user/userguide/events.diviner
··· 182 182 This is similar to the previous event (will edit task) but occurs after the 183 183 edit completes. 184 184 185 - == Differential: Will Send Mail == 186 - 187 - The constant for this event is 188 - `PhabricatorEventType::TYPE_DIFFERENTIAL_WILLSENDMAIL` 189 - 190 - This event is dispatched before Differential sends an email, and allows you to 191 - edit the message that will be sent. Data available on this event: 192 - 193 - - ##mail## The @{class:PhabricatorMetaMTAMail} being edited. 194 - 195 185 == Differential: Will Mark Generated == 196 186 197 187 The constant for this event is ··· 203 193 - ##corpus## Body of the file. 204 194 - ##is_generated## Boolean indicating if this file should be treated as 205 195 generated. 206 - 207 - == Differential: Will Edit Revision == 208 - 209 - The constant for this event is 210 - `PhabricatorEventType::TYPE_DIFFERENTIAL_WILLEDITREVISION`. 211 - 212 - This event is dispatched before a revision is edited, and allows you to 213 - respond to or alter the edit. Data available on this event: 214 - 215 - - ##revision## The @{class:DifferentialRevision} being edited. 216 - - ##new## A boolean indicating if this revision is being created. 217 - 218 - This is similar to the next event (did edit revision) but occurs before the edit 219 - begins. 220 - 221 - == Differential: Did Edit Revision == 222 - 223 - The constant for this event is 224 - `PhabricatorEventType::TYPE_DIFFERENTIAL_DIDEDITREVISION`. 225 - 226 - This event is dispatched after a revision is edited, and allows you to 227 - react to the edit. Data available on this event: 228 - 229 - - ##revision## The @{class:DifferentialRevision} being edited. 230 - - ##new## A boolean indicating if this revision is being created. 231 - 232 - This is similar to the previous event (will edit revision) but occurs after the 233 - edit completes. 234 196 235 197 == Diffusion: Did Discover Commit == 236 198
-3
src/infrastructure/events/constant/PhabricatorEventType.php
··· 13 13 const TYPE_MANIPHEST_WILLEDITTASK = 'maniphest.willEditTask'; 14 14 const TYPE_MANIPHEST_DIDEDITTASK = 'maniphest.didEditTask'; 15 15 16 - const TYPE_DIFFERENTIAL_WILLSENDMAIL = 'differential.willSendMail'; 17 16 const TYPE_DIFFERENTIAL_WILLMARKGENERATED = 'differential.willMarkGenerated'; 18 - const TYPE_DIFFERENTIAL_WILLEDITREVISION = 'differential.willEditRevision'; 19 - const TYPE_DIFFERENTIAL_DIDEDITREVISION = 'differential.didEditRevision'; 20 17 21 18 const TYPE_DIFFUSION_DIDDISCOVERCOMMIT = 'diffusion.didDiscoverCommit'; 22 19 const TYPE_DIFFUSION_LOOKUPUSER = 'diffusion.lookupUser';