@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some Paste scroll issues
Summary:
- If a Paste has very long lines, we show far too much text in the summary, because we wrap the lines. Instead, overflow them.
- If a Paste has very long unbroken lines (MMMMM...), they extend past the page. Instead, add a scrollable container.
Test Plan:
{F27868}
{F27869}
{F27870}
Reviewers: btrahan, codeblock, chad
Reviewed By: codeblock
CC: aran
Differential Revision: https://secure.phabricator.com/D4211
+24
-4
+1
-1
src/__celerity_resource_map__.php
+1
-1
src/__celerity_resource_map__.php
···
2810
2810
),
2811
2811
'phabricator-source-code-view-css' =>
2812
2812
array(
2813
-
'uri' => '/res/aa04c202/rsrc/css/layout/phabricator-source-code-view.css',
2813
+
'uri' => '/res/87935c75/rsrc/css/layout/phabricator-source-code-view.css',
2814
2814
'type' => 'css',
2815
2815
'requires' =>
2816
2816
array(
+8
-3
src/view/layout/PhabricatorSourceCodeView.php
+8
-3
src/view/layout/PhabricatorSourceCodeView.php
···
67
67
$classes[] = 'PhabricatorMonospaced';
68
68
69
69
return phutil_render_tag(
70
-
'table',
70
+
'div',
71
71
array(
72
-
'class' => implode(' ', $classes),
72
+
'class' => 'phabricator-source-code-container',
73
73
),
74
-
implode('', $rows));
74
+
phutil_render_tag(
75
+
'table',
76
+
array(
77
+
'class' => implode(' ', $classes),
78
+
),
79
+
implode('', $rows)));
75
80
}
76
81
77
82
}
+15
webroot/rsrc/css/layout/phabricator-source-code-view.css
+15
webroot/rsrc/css/layout/phabricator-source-code-view.css
···
2
2
* @provides phabricator-source-code-view-css
3
3
*/
4
4
5
+
.phabricator-source-code-container {
6
+
overflow-x: auto;
7
+
overflow-y: hidden;
8
+
}
9
+
5
10
.phabricator-source-code {
6
11
white-space: pre-wrap;
7
12
padding: 2px 8px 1px;
···
28
33
.phabricator-source-code-summary {
29
34
margin-bottom: 4px;
30
35
}
36
+
37
+
/* If a Paste has enormously long lines, truncate them in the summary on the
38
+
list page. They'll be fully visible on the Paste itself. */
39
+
.phabricator-source-code-summary .phabricator-source-code-container {
40
+
overflow-x: hidden;
41
+
}
42
+
43
+
.phabricator-source-code-summary .phabricator-source-code {
44
+
white-space: nowrap;
45
+
}