recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract

Summary: Fixes T9625. As explained in a `TODO` comment, seems reasonable enough.

Test Plan: Unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, hach-que

Maniphest Tasks: T9625

Differential Revision: https://secure.phabricator.com/D14068

Joshua Spence 495cb7a2 09d4ea88

+347 -76
+4
src/applications/almanac/phid/AlmanacBindingPHIDType.php
··· 12 12 return new AlmanacBinding(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAlmanacApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/almanac/phid/AlmanacDevicePHIDType.php
··· 12 12 return new AlmanacDevice(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAlmanacApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/almanac/phid/AlmanacInterfacePHIDType.php
··· 12 12 return new AlmanacInterface(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAlmanacApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/almanac/phid/AlmanacNetworkPHIDType.php
··· 12 12 return new AlmanacNetwork(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAlmanacApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/almanac/phid/AlmanacServicePHIDType.php
··· 12 12 return new AlmanacService(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAlmanacApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php
··· 12 12 return new PhabricatorAuthFactorConfig(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAuthApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php
··· 12 12 return new PhabricatorAuthProviderConfig(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAuthApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php
··· 12 12 return new PhabricatorAuthInvite(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorAuthApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
··· 8 8 return pht('Event'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorCalendarApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new PhabricatorCalendarEvent(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorCalendarApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4
src/applications/config/phid/PhabricatorConfigConfigPHIDType.php
··· 12 12 return new PhabricatorConfigEntry(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorConfigApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
··· 12 12 return new PhabricatorCountdown(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorCountdownApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php
··· 12 12 return new PhabricatorDashboard(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDashboardApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php
··· 12 12 return new PhabricatorDashboardPanel(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDashboardApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/differential/phid/DifferentialDiffPHIDType.php
··· 12 12 return new DifferentialDiff(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDifferentialApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/differential/phid/DifferentialRevisionPHIDType.php
··· 8 8 return pht('Differential Revision'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorDifferentialApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new DifferentialRevision(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDifferentialApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4
src/applications/drydock/phid/DrydockAuthorizationPHIDType.php
··· 12 12 return new DrydockAuthorization(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDrydockApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/drydock/phid/DrydockBlueprintPHIDType.php
··· 8 8 return pht('Blueprint'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorDrydockApplication'; 13 - } 14 - 15 11 public function getTypeIcon() { 16 12 return 'fa-map-o'; 17 13 } 18 14 19 15 public function newObject() { 20 16 return new DrydockBlueprint(); 17 + } 18 + 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorDrydockApplication'; 21 21 } 22 22 23 23 protected function buildQueryForObjects(
+4 -4
src/applications/drydock/phid/DrydockLeasePHIDType.php
··· 8 8 return pht('Drydock Lease'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorDrydockApplication'; 13 - } 14 - 15 11 public function getTypeIcon() { 16 12 return 'fa-link'; 17 13 } 18 14 19 15 public function newObject() { 20 16 return new DrydockLease(); 17 + } 18 + 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorDrydockApplication'; 21 21 } 22 22 23 23 protected function buildQueryForObjects(
+4
src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php
··· 12 12 return new DrydockRepositoryOperation(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDrydockApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/drydock/phid/DrydockResourcePHIDType.php
··· 8 8 return pht('Drydock Resource'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorDrydockApplication'; 13 - } 14 - 15 11 public function getTypeIcon() { 16 12 return 'fa-map'; 17 13 } 18 14 19 15 public function newObject() { 20 16 return new DrydockResource(); 17 + } 18 + 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorDrydockApplication'; 21 21 } 22 22 23 23 protected function buildQueryForObjects(
+4
src/applications/files/phid/PhabricatorFileFilePHIDType.php
··· 12 12 return new PhabricatorFile(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorFilesApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/fund/phid/FundBackerPHIDType.php
··· 12 12 return new FundInitiative(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorFundApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php
··· 12 12 return new HarbormasterBuildArtifact(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorHarbormasterApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php
··· 12 12 return new HarbormasterBuildLog(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorHarbormasterApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php
··· 12 12 return new HarbormasterBuild(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorHarbormasterApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php
··· 16 16 return new HarbormasterBuildPlan(); 17 17 } 18 18 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorHarbormasterApplication'; 21 + } 22 + 19 23 protected function buildQueryForObjects( 20 24 PhabricatorObjectQuery $query, 21 25 array $phids) {
+4
src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php
··· 12 12 return new HarbormasterBuildStep(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorHarbormasterApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php
··· 12 12 return new HarbormasterBuildTarget(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorHarbormasterApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php
··· 12 12 return new HarbormasterBuildable(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorHarbormasterApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/herald/phid/HeraldRulePHIDType.php
··· 12 12 return new HeraldRule(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorHeraldApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php
··· 16 16 return new LegalpadDocument(); 17 17 } 18 18 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorLegalpadApplication'; 21 + } 22 + 19 23 protected function buildQueryForObjects( 20 24 PhabricatorObjectQuery $query, 21 25 array $phids) {
+4 -4
src/applications/maniphest/phid/ManiphestTaskPHIDType.php
··· 8 8 return pht('Maniphest Task'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorManiphestApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new ManiphestTask(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorManiphestApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4
src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php
··· 17 17 return null; 18 18 } 19 19 20 + public function getPHIDTypeApplicationClass() { 21 + return 'PhabricatorApplicationsApplication'; 22 + } 23 + 20 24 protected function buildQueryForObjects( 21 25 PhabricatorObjectQuery $query, 22 26 array $phids) {
+4 -4
src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php
··· 8 8 return pht('MetaMTA Mail'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorMetaMTAApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new PhabricatorMetaMTAMail(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorMetaMTAApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4
src/applications/nuance/phid/NuanceItemPHIDType.php
··· 12 12 return new NuanceItem(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorNuanceApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/nuance/phid/NuanceQueuePHIDType.php
··· 12 12 return new NuanceQueue(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorNuanceApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/nuance/phid/NuanceRequestorPHIDType.php
··· 12 12 return new NuanceRequestor(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorNuanceApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/nuance/phid/NuanceSourcePHIDType.php
··· 12 12 return new NuanceSource(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorNuanceApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php
··· 13 13 return new PhabricatorOAuthClientAuthorization(); 14 14 } 15 15 16 + public function getPHIDTypeApplicationClass() { 17 + return 'PhabricatorOAuthServerApplication'; 18 + } 19 + 16 20 protected function buildQueryForObjects( 17 21 PhabricatorObjectQuery $query, 18 22 array $phids) {
+4
src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php
··· 12 12 return new PhabricatorOAuthServerClient(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorOAuthServerApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php
··· 16 16 return new PhabricatorOwnersPackage(); 17 17 } 18 18 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorOwnersApplication'; 21 + } 22 + 19 23 protected function buildQueryForObjects( 20 24 PhabricatorObjectQuery $query, 21 25 array $phids) {
+4
src/applications/paste/phid/PhabricatorPastePastePHIDType.php
··· 12 12 return new PhabricatorPaste(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPasteApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php
··· 12 12 return new PhabricatorExternalAccount(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPeopleApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/people/phid/PhabricatorPeopleUserPHIDType.php
··· 8 8 return pht('User'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorPeopleApplication'; 13 - } 14 - 15 11 public function getTypeIcon() { 16 12 return 'fa-user bluegrey'; 17 13 } 18 14 19 15 public function newObject() { 20 16 return new PhabricatorUser(); 17 + } 18 + 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorPeopleApplication'; 21 21 } 22 22 23 23 protected function buildQueryForObjects(
+4
src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php
··· 12 12 return new PhameBlog(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhameApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phame/phid/PhabricatorPhamePostPHIDType.php
··· 12 12 return new PhamePost(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhameApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php
··· 9 9 return pht('Application Email'); 10 10 } 11 11 12 - public function getPHIDTypeApplicationClass() { 13 - return 'PhabricatorMetaMTAApplication'; 14 - } 15 - 16 12 public function getTypeIcon() { 17 13 return 'fa-email bluegrey'; 18 14 } 19 15 20 16 public function newObject() { 21 17 return new PhabricatorMetaMTAApplicationEmail(); 18 + } 19 + 20 + public function getPHIDTypeApplicationClass() { 21 + return 'PhabricatorMetaMTAApplication'; 22 22 } 23 23 24 24 protected function buildQueryForObjects(
+5 -10
src/applications/phid/type/PhabricatorPHIDType.php
··· 20 20 21 21 abstract public function getTypeName(); 22 22 23 - public function newObject() { 24 - return null; 25 - } 26 - 27 23 public function getTypeIcon() { 28 24 // Default to the application icon if the type doesn't specify one. 29 25 $application_class = $this->getPHIDTypeApplicationClass(); ··· 32 28 return $application->getFontIcon(); 33 29 } 34 30 31 + return null; 32 + } 33 + 34 + public function newObject() { 35 35 return null; 36 36 } 37 37 ··· 42 42 * @return string|null Class name of the corresponding application, or null 43 43 * if the type is not bound to an application. 44 44 */ 45 - public function getPHIDTypeApplicationClass() { 46 - // TODO: Some day this should probably be abstract, but for now it only 47 - // affects global search and there's no real burning need to go classify 48 - // every PHID type. 49 - return null; 50 - } 45 + abstract public function getPHIDTypeApplicationClass(); 51 46 52 47 /** 53 48 * Build a @{class:PhabricatorPolicyAwareQuery} to load objects of this type
+12
src/applications/phid/type/__tests__/PhabricatorPHIDTypeTestCase.php
··· 7 7 $this->assertTrue(true); 8 8 } 9 9 10 + public function testGetPHIDTypeApplicationClass() { 11 + $types = PhabricatorPHIDType::getAllTypes(); 12 + 13 + foreach ($types as $type) { 14 + $application_class = $type->getPHIDTypeApplicationClass(); 15 + 16 + if ($application_class !== null) { 17 + $this->assertTrue(class_exists($application_class)); 18 + } 19 + } 20 + } 21 + 10 22 }
+4
src/applications/phlux/phid/PhluxVariablePHIDType.php
··· 12 12 return new PhluxVariable(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhluxApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/pholio/phid/PholioImagePHIDType.php
··· 12 12 return new PholioImage(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPholioApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/pholio/phid/PholioMockPHIDType.php
··· 8 8 return pht('Pholio Mock'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorPholioApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new PholioMock(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPholioApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4
src/applications/phortune/phid/PhortuneAccountPHIDType.php
··· 12 12 return new PhortuneAccount(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortuneCartPHIDType.php
··· 12 12 return new PhortuneCart(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortuneChargePHIDType.php
··· 12 12 return new PhortuneCharge(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortuneMerchantPHIDType.php
··· 12 12 return new PhortuneMerchant(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php
··· 12 12 return new PhortunePaymentMethod(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php
··· 12 12 return new PhortunePaymentProviderConfig(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortuneProductPHIDType.php
··· 12 12 return new PhortuneProduct(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortunePurchasePHIDType.php
··· 12 12 return new PhortunePurchase(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php
··· 12 12 return new PhortuneSubscription(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhortuneApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phragment/phid/PhragmentFragmentPHIDType.php
··· 12 12 return new PhragmentFragment(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhragmentApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php
··· 12 12 return new PhragmentFragmentVersion(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhragmentApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/phragment/phid/PhragmentSnapshotPHIDType.php
··· 12 12 return new PhragmentSnapshot(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhragmentApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/phriction/phid/PhrictionDocumentPHIDType.php
··· 8 8 return pht('Phriction Wiki Document'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorPhrictionApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new PhrictionDocument(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhrictionApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4 -4
src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php
··· 8 8 return pht('URL'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorPhurlApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new PhabricatorPhurlURL(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPhurlApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4
src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php
··· 12 12 return new PhabricatorPolicy(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPolicyApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/ponder/phid/PonderQuestionPHIDType.php
··· 8 8 return pht('Ponder Question'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorPonderApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new PonderQuestion(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorPonderApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+6 -2
src/applications/project/phid/PhabricatorProjectColumnPHIDType.php
··· 8 8 return pht('Project Column'); 9 9 } 10 10 11 + public function getTypeIcon() { 12 + return 'fa-columns bluegrey'; 13 + } 14 + 11 15 public function newObject() { 12 16 return new PhabricatorProjectColumn(); 13 17 } 14 18 15 - public function getTypeIcon() { 16 - return 'fa-columns bluegrey'; 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorProjectApplication'; 17 21 } 18 22 19 23 protected function buildQueryForObjects(
+4 -4
src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
··· 8 8 return pht('Project'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorProjectApplication'; 13 - } 14 - 15 11 public function getTypeIcon() { 16 12 return 'fa-briefcase bluegrey'; 17 13 } 18 14 19 15 public function newObject() { 20 16 return new PhabricatorProject(); 17 + } 18 + 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorProjectApplication'; 21 21 } 22 22 23 23 protected function buildQueryForObjects(
+4
src/applications/releeph/phid/ReleephBranchPHIDType.php
··· 12 12 return new ReleephBranch(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorReleephApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/releeph/phid/ReleephProductPHIDType.php
··· 12 12 return new ReleephProject(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorReleephApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/releeph/phid/ReleephRequestPHIDType.php
··· 12 12 return new ReleephRequest(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorReleephApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php
··· 8 8 return pht('Diffusion Commit'); 9 9 } 10 10 11 - public function getPHIDTypeApplicationClass() { 12 - return 'PhabricatorDiffusionApplication'; 13 - } 14 - 15 11 public function newObject() { 16 12 return new PhabricatorRepositoryCommit(); 13 + } 14 + 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDiffusionApplication'; 17 17 } 18 18 19 19 protected function buildQueryForObjects(
+4
src/applications/repository/phid/PhabricatorRepositoryMirrorPHIDType.php
··· 12 12 return new PhabricatorRepositoryMirror(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDiffusionApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/repository/phid/PhabricatorRepositoryPushEventPHIDType.php
··· 12 12 return new PhabricatorRepositoryPushEvent(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDiffusionApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/repository/phid/PhabricatorRepositoryPushLogPHIDType.php
··· 12 12 return new PhabricatorRepositoryPushLog(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDiffusionApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php
··· 17 17 return new PhabricatorRepository(); 18 18 } 19 19 20 + public function getPHIDTypeApplicationClass() { 21 + return 'PhabricatorDiffusionApplication'; 22 + } 23 + 20 24 protected function buildQueryForObjects( 21 25 PhabricatorObjectQuery $query, 22 26 array $phids) {
+4
src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php
··· 12 12 return new PhabricatorSlowvotePoll(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorSlowvoteApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4 -4
src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php
··· 9 9 return pht('Space'); 10 10 } 11 11 12 - public function getPHIDTypeApplicationClass() { 13 - return 'PhabricatorSpacesApplication'; 14 - } 15 - 16 12 public function newObject() { 17 13 return new PhabricatorSpacesNamespace(); 14 + } 15 + 16 + public function getPHIDTypeApplicationClass() { 17 + return 'PhabricatorSpacesApplication'; 18 18 } 19 19 20 20 protected function buildQueryForObjects(
+4
src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php
··· 12 12 return new PhabricatorToken(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorTokensApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/applications/transactions/phid/PhabricatorApplicationTransactionTransactionPHIDType.php
··· 16 16 return null; 17 17 } 18 18 19 + public function getPHIDTypeApplicationClass() { 20 + return 'PhabricatorTransactionsApplication'; 21 + } 22 + 19 23 protected function buildQueryForObjects( 20 24 PhabricatorObjectQuery $object_query, 21 25 array $phids) {
+4
src/infrastructure/daemon/workers/phid/PhabricatorWorkerBulkJobPHIDType.php
··· 12 12 return new PhabricatorWorkerBulkJob(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDaemonsApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {
+4
src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php
··· 12 12 return new PhabricatorWorkerTrigger(); 13 13 } 14 14 15 + public function getPHIDTypeApplicationClass() { 16 + return 'PhabricatorDaemonsApplication'; 17 + } 18 + 15 19 protected function buildQueryForObjects( 16 20 PhabricatorObjectQuery $query, 17 21 array $phids) {