@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove hovercards from Feed panels on dashboards
Summary:
Fixes T5472.
I do imagine doing a pass on the Hovercard JS at some point to try to make them position more intelligently (I've hit a few cases where they do something silly, and we can probably fix many of them), but generally agree that this is inconsistent and questionably valuable on panels.
Test Plan:
- Moused over feed stuff in a panel, no hovercards.
- Moused over feed stuff in Feed, got hovercards.
Reviewers: chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T5472
Differential Revision: https://secure.phabricator.com/D9753
+7
-1
+7
-1
src/applications/feed/query/PhabricatorFeedSearchEngine.php
+7
-1
src/applications/feed/query/PhabricatorFeedSearchEngine.php
···
134
134
array $handles) {
135
135
136
136
$builder = new PhabricatorFeedBuilder($objects);
137
-
$builder->setShowHovercards(true);
137
+
138
+
if ($this->isPanelContext()) {
139
+
$builder->setShowHovercards(false);
140
+
} else {
141
+
$builder->setShowHovercards(true);
142
+
}
143
+
138
144
$builder->setUser($this->requireViewer());
139
145
$view = $builder->buildView();
140
146