@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix credential upgrade issue after introduction of `isLocked` column
Summary: Fixes T5035. This migration isn't forward compatible after schema mutation.
Test Plan: Ran locally, will get reporting user to confirm.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: gera, epriestley
Maniphest Tasks: T5035
Differential Revision: https://secure.phabricator.com/D9101
+23
-2
+23
-2
resources/sql/patches/20131121.repocredentials.2.mig.php
+23
-2
resources/sql/patches/20131121.repocredentials.2.mig.php
···
86
86
->setEditPolicy(PhabricatorPolicies::POLICY_ADMIN)
87
87
->setName($name)
88
88
->setUsername($username)
89
-
->setSecretID($secret_id)
90
-
->save();
89
+
->setSecretID($secret_id);
90
+
91
+
$credential->setPHID($credential->generatePHID());
92
+
93
+
queryfx(
94
+
$credential->establishConnection('w'),
95
+
'INSERT INTO %T (name, credentialType, providesType, viewPolicy,
96
+
editPolicy, description, username, secretID, isDestroyed,
97
+
phid, dateCreated, dateModified)
98
+
VALUES (%s, %s, %s, %s, %s, %s, %s, %d, %d, %s, %d, %d)',
99
+
$credential->getTableName(),
100
+
$credential->getName(),
101
+
$credential->getCredentialType(),
102
+
$credential->getProvidesType(),
103
+
$credential->getViewPolicy(),
104
+
$credential->getEditPolicy(),
105
+
$credential->getDescription(),
106
+
$credential->getUsername(),
107
+
$credential->getSecretID(),
108
+
$credential->getIsDestroyed(),
109
+
$credential->getPHID(),
110
+
time(),
111
+
time());
91
112
92
113
foreach ($repositories as $repository) {
93
114
queryfx(