@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Tweaking Widget Panel in Conpherence
Summary:
Fixes T3252. Other enhancements:
- Header in widget panel was 2px too short.
- Typeahead in add people only allowed one person
- Typeahead in add people was cutoff by overflow:hidden
- X in remove has been changed to unicode (multiply)
- Add people dialog form fields are full width
- Some other CSS tweaks.
Test Plan: Add, Remove people.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T3252
Differential Revision: https://secure.phabricator.com/D6076
+75
-82
+47
-47
src/__celerity_resource_map__.php
+47
-47
src/__celerity_resource_map__.php
···
782
782
),
783
783
'aphront-dialog-view-css' =>
784
784
array(
785
-
'uri' => '/res/7060a2fe/rsrc/css/aphront/dialog-view.css',
785
+
'uri' => '/res/75663cde/rsrc/css/aphront/dialog-view.css',
786
786
'type' => 'css',
787
787
'requires' =>
788
788
array(
···
945
945
),
946
946
'conpherence-widget-pane-css' =>
947
947
array(
948
-
'uri' => '/res/40be33e2/rsrc/css/application/conpherence/widget-pane.css',
948
+
'uri' => '/res/5aa0a316/rsrc/css/application/conpherence/widget-pane.css',
949
949
'type' => 'css',
950
950
'requires' =>
951
951
array(
···
3973
3973
), array(
3974
3974
'packages' =>
3975
3975
array(
3976
-
'bce72de6' =>
3976
+
'b7428f7c' =>
3977
3977
array(
3978
3978
'name' => 'core.pkg.css',
3979
3979
'symbols' =>
···
4022
4022
41 => 'phabricator-property-list-view-css',
4023
4023
42 => 'phabricator-tag-view-css',
4024
4024
),
4025
-
'uri' => '/res/pkg/bce72de6/core.pkg.css',
4025
+
'uri' => '/res/pkg/b7428f7c/core.pkg.css',
4026
4026
'type' => 'css',
4027
4027
),
4028
4028
'98f60e3f' =>
···
4216
4216
'reverse' =>
4217
4217
array(
4218
4218
'aphront-attached-file-view-css' => '6b1fccc6',
4219
-
'aphront-dialog-view-css' => 'bce72de6',
4220
-
'aphront-error-view-css' => 'bce72de6',
4221
-
'aphront-form-view-css' => 'bce72de6',
4222
-
'aphront-list-filter-view-css' => 'bce72de6',
4223
-
'aphront-pager-view-css' => 'bce72de6',
4224
-
'aphront-panel-view-css' => 'bce72de6',
4225
-
'aphront-table-view-css' => 'bce72de6',
4226
-
'aphront-tokenizer-control-css' => 'bce72de6',
4227
-
'aphront-tooltip-css' => 'bce72de6',
4228
-
'aphront-typeahead-control-css' => 'bce72de6',
4219
+
'aphront-dialog-view-css' => 'b7428f7c',
4220
+
'aphront-error-view-css' => 'b7428f7c',
4221
+
'aphront-form-view-css' => 'b7428f7c',
4222
+
'aphront-list-filter-view-css' => 'b7428f7c',
4223
+
'aphront-pager-view-css' => 'b7428f7c',
4224
+
'aphront-panel-view-css' => 'b7428f7c',
4225
+
'aphront-table-view-css' => 'b7428f7c',
4226
+
'aphront-tokenizer-control-css' => 'b7428f7c',
4227
+
'aphront-tooltip-css' => 'b7428f7c',
4228
+
'aphront-typeahead-control-css' => 'b7428f7c',
4229
4229
'differential-changeset-view-css' => 'dd27a69b',
4230
4230
'differential-core-view-css' => 'dd27a69b',
4231
4231
'differential-inline-comment-editor' => '9488bb69',
···
4239
4239
'differential-table-of-contents-css' => 'dd27a69b',
4240
4240
'diffusion-commit-view-css' => 'c8ce2d88',
4241
4241
'diffusion-icons-css' => 'c8ce2d88',
4242
-
'global-drag-and-drop-css' => 'bce72de6',
4242
+
'global-drag-and-drop-css' => 'b7428f7c',
4243
4243
'inline-comment-summary-css' => 'dd27a69b',
4244
4244
'javelin-aphlict' => '98f60e3f',
4245
4245
'javelin-behavior' => 'c1359b5d',
···
4313
4313
'javelin-util' => 'c1359b5d',
4314
4314
'javelin-vector' => 'c1359b5d',
4315
4315
'javelin-workflow' => 'c1359b5d',
4316
-
'lightbox-attachment-css' => 'bce72de6',
4316
+
'lightbox-attachment-css' => 'b7428f7c',
4317
4317
'maniphest-task-summary-css' => '6b1fccc6',
4318
4318
'maniphest-transaction-detail-css' => '6b1fccc6',
4319
-
'phabricator-action-list-view-css' => 'bce72de6',
4320
-
'phabricator-application-launch-view-css' => 'bce72de6',
4319
+
'phabricator-action-list-view-css' => 'b7428f7c',
4320
+
'phabricator-application-launch-view-css' => 'b7428f7c',
4321
4321
'phabricator-busy' => '98f60e3f',
4322
4322
'phabricator-content-source-view-css' => 'dd27a69b',
4323
-
'phabricator-core-buttons-css' => 'bce72de6',
4324
-
'phabricator-core-css' => 'bce72de6',
4325
-
'phabricator-crumbs-view-css' => 'bce72de6',
4326
-
'phabricator-directory-css' => 'bce72de6',
4323
+
'phabricator-core-buttons-css' => 'b7428f7c',
4324
+
'phabricator-core-css' => 'b7428f7c',
4325
+
'phabricator-crumbs-view-css' => 'b7428f7c',
4326
+
'phabricator-directory-css' => 'b7428f7c',
4327
4327
'phabricator-drag-and-drop-file-upload' => '9488bb69',
4328
4328
'phabricator-dropdown-menu' => '98f60e3f',
4329
4329
'phabricator-file-upload' => '98f60e3f',
4330
-
'phabricator-filetree-view-css' => 'bce72de6',
4331
-
'phabricator-flag-css' => 'bce72de6',
4332
-
'phabricator-form-view-css' => 'bce72de6',
4333
-
'phabricator-header-view-css' => 'bce72de6',
4330
+
'phabricator-filetree-view-css' => 'b7428f7c',
4331
+
'phabricator-flag-css' => 'b7428f7c',
4332
+
'phabricator-form-view-css' => 'b7428f7c',
4333
+
'phabricator-header-view-css' => 'b7428f7c',
4334
4334
'phabricator-hovercard' => '98f60e3f',
4335
-
'phabricator-jump-nav' => 'bce72de6',
4335
+
'phabricator-jump-nav' => 'b7428f7c',
4336
4336
'phabricator-keyboard-shortcut' => '98f60e3f',
4337
4337
'phabricator-keyboard-shortcut-manager' => '98f60e3f',
4338
-
'phabricator-main-menu-view' => 'bce72de6',
4338
+
'phabricator-main-menu-view' => 'b7428f7c',
4339
4339
'phabricator-menu-item' => '98f60e3f',
4340
-
'phabricator-nav-view-css' => 'bce72de6',
4340
+
'phabricator-nav-view-css' => 'b7428f7c',
4341
4341
'phabricator-notification' => '98f60e3f',
4342
-
'phabricator-notification-css' => 'bce72de6',
4343
-
'phabricator-notification-menu-css' => 'bce72de6',
4344
-
'phabricator-object-item-list-view-css' => 'bce72de6',
4342
+
'phabricator-notification-css' => 'b7428f7c',
4343
+
'phabricator-notification-menu-css' => 'b7428f7c',
4344
+
'phabricator-object-item-list-view-css' => 'b7428f7c',
4345
4345
'phabricator-object-selector-css' => 'dd27a69b',
4346
4346
'phabricator-phtize' => '98f60e3f',
4347
4347
'phabricator-prefab' => '98f60e3f',
4348
4348
'phabricator-project-tag-css' => '6b1fccc6',
4349
-
'phabricator-property-list-view-css' => 'bce72de6',
4350
-
'phabricator-remarkup-css' => 'bce72de6',
4349
+
'phabricator-property-list-view-css' => 'b7428f7c',
4350
+
'phabricator-remarkup-css' => 'b7428f7c',
4351
4351
'phabricator-shaped-request' => '9488bb69',
4352
-
'phabricator-side-menu-view-css' => 'bce72de6',
4353
-
'phabricator-standard-page-view' => 'bce72de6',
4354
-
'phabricator-tag-view-css' => 'bce72de6',
4352
+
'phabricator-side-menu-view-css' => 'b7428f7c',
4353
+
'phabricator-standard-page-view' => 'b7428f7c',
4354
+
'phabricator-tag-view-css' => 'b7428f7c',
4355
4355
'phabricator-textareautils' => '98f60e3f',
4356
4356
'phabricator-tooltip' => '98f60e3f',
4357
-
'phabricator-transaction-view-css' => 'bce72de6',
4358
-
'phabricator-zindex-css' => 'bce72de6',
4359
-
'phui-form-css' => 'bce72de6',
4360
-
'phui-icon-view-css' => 'bce72de6',
4361
-
'spacing-css' => 'bce72de6',
4362
-
'sprite-apps-large-css' => 'bce72de6',
4363
-
'sprite-gradient-css' => 'bce72de6',
4364
-
'sprite-icons-css' => 'bce72de6',
4365
-
'sprite-menu-css' => 'bce72de6',
4366
-
'syntax-highlighting-css' => 'bce72de6',
4357
+
'phabricator-transaction-view-css' => 'b7428f7c',
4358
+
'phabricator-zindex-css' => 'b7428f7c',
4359
+
'phui-form-css' => 'b7428f7c',
4360
+
'phui-icon-view-css' => 'b7428f7c',
4361
+
'spacing-css' => 'b7428f7c',
4362
+
'sprite-apps-large-css' => 'b7428f7c',
4363
+
'sprite-gradient-css' => 'b7428f7c',
4364
+
'sprite-icons-css' => 'b7428f7c',
4365
+
'sprite-menu-css' => 'b7428f7c',
4366
+
'syntax-highlighting-css' => 'b7428f7c',
4367
4367
),
4368
4368
));
+11
-8
src/applications/conpherence/controller/ConpherenceUpdateController.php
+11
-8
src/applications/conpherence/controller/ConpherenceUpdateController.php
···
181
181
$user = $request->getUser();
182
182
$add_person = $request->getStr('add_person');
183
183
184
-
$body = id(new AphrontFormTokenizerControl())
185
-
->setPlaceholder(pht('Add participants...'))
186
-
->setName('add_person')
184
+
$form = id(new AphrontFormLayoutView())
187
185
->setUser($user)
188
-
->setDatasource('/typeahead/common/users/')
189
-
->setLimit(1);
186
+
->setFullWidth(true)
187
+
->appendChild(
188
+
id(new AphrontFormTokenizerControl())
189
+
->setName('add_person')
190
+
->setUser($user)
191
+
->setDatasource('/typeahead/common/users/'));
190
192
191
193
require_celerity_resource('conpherence-update-css');
192
194
return id(new AphrontDialogView())
193
-
->setTitle(pht('Update Conpherence Participants'))
195
+
->setTitle(pht('Add Participants'))
194
196
->addHiddenInput('action', 'add_person')
195
-
->appendChild($body);
197
+
->appendChild($form);
196
198
}
197
199
198
200
private function renderRemovePersonDialogue(
···
219
221
220
222
require_celerity_resource('conpherence-update-css');
221
223
return id(new AphrontDialogView())
222
-
->setTitle(pht('Update Conpherence Participants'))
224
+
->setTitle(pht('Remove Participants'))
225
+
->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED)
223
226
->addHiddenInput('action', 'remove_person')
224
227
->addHiddenInput('__continue__', true)
225
228
->addHiddenInput('remove_person', $remove_person)
+2
-7
src/applications/conpherence/view/ConpherencePeopleWidgetView.php
+2
-7
src/applications/conpherence/view/ConpherencePeopleWidgetView.php
···
29
29
'action' => 'remove_person',
30
30
)
31
31
),
32
-
phutil_tag(
33
-
'span',
34
-
array(
35
-
'class' => 'icon'
36
-
),
37
-
'x'));
32
+
hsprintf('<span class="close-icon">×</span>'));
38
33
}
39
34
$body[] = phutil_tag(
40
35
'div',
41
36
array(
42
-
'class' => 'person-entry'
37
+
'class' => 'person-entry grouped'
43
38
),
44
39
array(
45
40
phutil_tag(
+6
-3
src/view/AphrontDialogView.php
+6
-3
src/view/AphrontDialogView.php
···
180
180
181
181
$content = hsprintf(
182
182
'%s%s%s',
183
-
phutil_tag('div', array('class' => 'aphront-dialog-head'), $header),
184
-
phutil_tag('div', array('class' => 'aphront-dialog-body'), $children),
185
-
phutil_tag('div', array('class' => 'aphront-dialog-tail'), $buttons));
183
+
phutil_tag('div',
184
+
array('class' => 'aphront-dialog-head'), $header),
185
+
phutil_tag('div',
186
+
array('class' => 'aphront-dialog-body grouped'), $children),
187
+
phutil_tag('div',
188
+
array('class' => 'aphront-dialog-tail'), $buttons));
186
189
187
190
if ($this->renderAsForm) {
188
191
return phabricator_form(
-1
webroot/rsrc/css/aphront/dialog-view.css
-1
webroot/rsrc/css/aphront/dialog-view.css
+9
-16
webroot/rsrc/css/application/conpherence/widget-pane.css
+9
-16
webroot/rsrc/css/application/conpherence/widget-pane.css
···
7
7
.loading .widgets-loading-icon {
8
8
position: fixed;
9
9
right: 0px;
10
-
top: 74px;
10
+
top: 76px;
11
11
bottom: 0px;
12
12
width: 240px;
13
13
border-width: 0 0 0 1px;
···
80
80
overflow-y: auto;
81
81
bottom: 0px;
82
82
width: 100%;
83
-
top: 74px;
83
+
top: 76px;
84
84
}
85
85
86
86
#widgets-settings {
···
88
88
}
89
89
90
90
.device-desktop .conpherence-widget-pane .widgets-body {
91
-
top: 106px;
91
+
top: 108px;
92
92
width: 240px;
93
93
}
94
94
···
343
343
}
344
344
345
345
.conpherence-widget-pane .person-entry {
346
-
clear: both;
347
-
padding: 10px 0px 0px 10px;
346
+
padding: 8px 0 0 8px;
348
347
}
349
348
350
349
.conpherence-widget-pane .person-entry a {
···
360
359
361
360
.conpherence-widget-pane .person-entry .pic {
362
361
float: left;
363
-
clear: left;
364
362
margin: 0 8px 0 0;
365
363
width: 35px;
366
364
padding: 0;
···
368
366
369
367
.conpherence-widget-pane .person-entry .remove {
370
368
float: right;
371
-
clear: right;
372
-
margin: 0;
373
369
width: 20px;
374
-
height: 20px;
375
-
text-align: center;
376
-
font-size: 22px;
377
-
font-weight: bold;
378
-
padding: 8px 0 8px 0p
370
+
font-size: 18px;
371
+
padding: 5px 0 8px 0;
379
372
}
380
373
381
374
.conpherence-widget-pane .person-entry .remove:hover {
382
375
text-decoration: none;
383
376
}
384
377
385
-
.conpherence-widget-pane .person-entry .remove .icon {
378
+
.conpherence-widget-pane .person-entry .remove .close-icon {
386
379
color: #bfbfbf;
387
380
}
388
381
389
-
.conpherence-widget-pane .person-entry .remove:hover .icon {
390
-
color: #18559d;
382
+
.conpherence-widget-pane .person-entry .remove:hover .close-icon {
383
+
color: #000;
391
384
}
392
385
393
386
/* settings widget */