recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't log lost connection retries

Summary:
In D1460, we added initial-connection retries and additional logging in response to network/router instability at Facebook.

One of these logs occurs normally, though, when daemons get disconnected by 'wait_timeout' settings. This is noisy for a lot of installs and a few people have asked me about it.

I assume the situation has cleared up a bit at Facebook, so we can remove the "business as usual" log and keep error logs quieter for general installs?

Test Plan: Weathered the support storm.

Reviewers: nh, vrana

Reviewed By: nh

CC: Makinde, aran

Differential Revision: https://secure.phabricator.com/D2736

epriestley 4ac1fa14 c868ec7d

-4
-4
src/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php
··· 199 199 if (!$retries) { 200 200 throw $ex; 201 201 } 202 - 203 - $class = get_class($ex); 204 - $message = $ex->getMessage(); 205 - phlog("Retrying ({$retries}) after {$class}: {$message}"); 206 202 } 207 203 } 208 204 }