@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't store IP addresses in content sources
Summary:
We don't use these for anything, we're inconsistent about recording them, and there's some mild interaction with privacy concerns and data retention. Every other log we store any kind of information in can be given a custom retention policy after recent GC changes.
If we did put this back eventually it would probably be better to store a session identifier anyway, since that's more granular and more detailed.
You can fetch this info out of access logs anyway, too.
Test Plan: Left a couple of comments.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D14315
+1
-3
+1
-3
src/applications/metamta/contentsource/PhabricatorContentSource.php
+1
-3
src/applications/metamta/contentsource/PhabricatorContentSource.php
···
54
54
public static function newFromRequest(AphrontRequest $request) {
55
55
return self::newForSource(
56
56
self::SOURCE_WEB,
57
-
array(
58
-
'ip' => $request->getRemoteAddr(),
59
-
));
57
+
array());
60
58
}
61
59
62
60
public static function newFromConduitRequest(ConduitAPIRequest $request) {