@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix application order, curing "Log Out" of wanderlust
Summary:
Fixes T3894. The "Log Out" icon has moved away from its rightmost position in the menubar.
In rP2e5ac12, I added a "Policy" application. This was the root cause.
The reordering logic (below) is slightly wrong. The `array_select_keys()` call is actually using the //strings// (like "Admnistration") to select the groups, not the correct constants (like "admin"). Use the constants instead and get the expected group ordering.
Test Plan: Loaded page, "Log Out" is in the rightmost position.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T3894
Differential Revision: https://secure.phabricator.com/D7177
+4
-1
+4
-1
src/applications/base/PhabricatorApplication.php
+4
-1
src/applications/base/PhabricatorApplication.php
···
270
270
// ensures their event handlers register in application order.
271
271
$apps = msort($apps, 'getApplicationOrder');
272
272
$apps = mgroup($apps, 'getApplicationGroup');
273
-
$apps = array_select_keys($apps, self::getApplicationGroups()) + $apps;
273
+
274
+
$group_order = array_keys(self::getApplicationGroups());
275
+
$apps = array_select_keys($apps, $group_order) + $apps;
276
+
274
277
$apps = array_mergev($apps);
275
278
276
279
$applications = $apps;