recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add "you can only enter one value" UI limits to Herald "set status" and "set priority" actions

Summary:
Ref T13048. Fixes T11112. I mostly fixed this before in D18887, but missed that these other actions are also affected. T11112 had a more complete list of missing limits.

(It's possible there are some others somewhere, but this is everything we know about, I think.)

Test Plan: Created rules using these actions, typed stuff into the box, was only able to enter one value.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048, T11112

Differential Revision: https://secure.phabricator.com/D18943

epriestley 4b5a78e3 7e772080

+4 -2
+2 -1
src/applications/maniphest/herald/ManiphestTaskPriorityHeraldAction.php
··· 61 61 } 62 62 63 63 protected function getDatasource() { 64 - return new ManiphestTaskPriorityDatasource(); 64 + return id(new ManiphestTaskPriorityDatasource()) 65 + ->setLimit(1); 65 66 } 66 67 67 68 protected function getDatasourceValueMap() {
+2 -1
src/applications/maniphest/herald/ManiphestTaskStatusHeraldAction.php
··· 58 58 } 59 59 60 60 protected function getDatasource() { 61 - return new ManiphestTaskStatusDatasource(); 61 + return id(new ManiphestTaskStatusDatasource()) 62 + ->setLimit(1); 62 63 } 63 64 64 65 protected function getDatasourceValueMap() {